{"object_kind":"push","event_name":"push","before":"6b038ef4dc05d6b469998e08ac61fd948a2b0c9a","after":"9303996b44bca8dd68796606b86efaae24e73d6c","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"9303996b44bca8dd68796606b86efaae24e73d6c","message":null,"user_id":94502,"user_name":"Jan Vaclav","user_username":"jvaclav","user_email":"jvaclav@redhat.com","user_avatar":"https://secure.gravatar.com/avatar/63438947499d1b23df20545a5f7834ebf1fd6a34a1d5f6baad97d6e2d40df256?s=80&d=identicon","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"4565c9efe4a4866dc0a3394276a20adb2a3bdb90","message":"policy: fix integer overflow in IPv6 PD subnet calculation\n\nThe literal `1` is a 32-bit int. When prefix length is less than 33,\nthe shift `(64 - plen)` exceeds 31 bits, causing undefined behavior.\nCast to guint64 (same type as `num_subnets`) to perform the shift in\n64-bit arithmetic.\n\nFound by Coverity (CID: OVERFLOW_BEFORE_WIDEN).\n\nFixes: ec12fcf6bf4f ('policy: delegate IPv6 configuration to ipv6.method=shared connections')\nCo-Authored-By: Claude Opus 4.6 \n","title":"policy: fix integer overflow in IPv6 PD subnet calculation","timestamp":"2026-04-14T12:53:43+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/4565c9efe4a4866dc0a3394276a20adb2a3bdb90","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/core/nm-policy.c"],"removed":[]},{"id":"56099c5e14043b9511cd76bf57bbc6c89c25bdb3","message":"device: fix potential null dereference when releasing port\n\nfind_port_info() can return NULL if the port is not registered.\nThe code dereferenced `info->port_state` before the null check,\nwhich would crash. Move the null check before the dereference.\n\nFound by Coverity (CID: REVERSE_INULL).\n\nFixes: a8329587c8bd ('device: fix bug when deactivating port connections asynchronously')\nCo-Authored-By: Claude Opus 4.6 \n","title":"device: fix potential null dereference when releasing port","timestamp":"2026-04-14T12:54:12+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/56099c5e14043b9511cd76bf57bbc6c89c25bdb3","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"8685ac184517d1852100f27fdc9e3fd1ce1d4154","message":"dns: fix infinite loop in assertion checking search domains\n\nThe loop condition checked the same pointer twice instead of checking\nthe array element: `ip_data->domains.search && ip_data->domains.search`\nshould be `ip_data->domains.search && ip_data->domains.search[i]`.\n\nAs written, the loop would never terminate when `search` is non-NULL\n(only in debug builds with NM_MORE_ASSERTS > 5).\n\nFound by Coverity (CID: CONSTANT_EXPRESSION_RESULT).\n\nFixes: b8dab47705dc ('dns: fix handling default routing domains with systemd-resolved')\nCo-Authored-By: Claude Opus 4.6 \n","title":"dns: fix infinite loop in assertion checking search domains","timestamp":"2026-04-14T12:54:12+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/8685ac184517d1852100f27fdc9e3fd1ce1d4154","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/core/dns/nm-dns-manager.c"],"removed":[]},{"id":"00f9a3d862b845246290ae1fbb9e59f0e00f0e06","message":"nmtui/wireguard: fix peer leak when adding new peer\n\nnm_wireguard_peer_new() returns a new peer with refcount 1.\nnmt_wireguard_peer_editor_new() takes its own copy via\ng_value_dup_boxed(), so the original peer was never unreffed.\n\nUnref the peer after passing it to the editor.\n\nFound by Coverity (CID: RESOURCE_LEAK).\n\nFixes: b0f5b1d97a65 ('tui: add WireGuard support to nmtui')\nCo-Authored-By: Claude Opus 4.6 \n","title":"nmtui/wireguard: fix peer leak when adding new peer","timestamp":"2026-04-14T12:54:12+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/00f9a3d862b845246290ae1fbb9e59f0e00f0e06","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/nmtui/nmt-wireguard-peer-list.c"],"removed":[]},{"id":"33871478b7cfdf717eff14de1f2928874d9352e1","message":"initrd: fix use-after-free when multiple iBFT entries fail\n\nThe error variable is declared outside the loop but freed with\ng_error_free() which does not reset the pointer to NULL. On the\nnext iteration, g_set_error() sees a non-NULL *err (dangling pointer)\nand error->message dereferences freed memory.\n\nUse g_clear_error() instead which also resets the pointer.\n\nFound by Coverity (CID: USE_AFTER_FREE).\n\nFixes: ecc074b2f8a6 ('initrd: add command line parser')\n\nCo-Authored-By: Claude Opus 4.6 \n","title":"initrd: fix use-after-free when multiple iBFT entries fail","timestamp":"2026-04-14T12:54:12+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/33871478b7cfdf717eff14de1f2928874d9352e1","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/nm-initrd-generator/nmi-cmdline-reader.c"],"removed":[]},{"id":"3d4ad7b4ba33a067396acb4a81f78273ada88b9a","message":"libnm: fix wrong variable in route attribute validation error message\n\nThe validation checks 'addr' (the extracted address portion before '/')\nbut the error message prints 'string' (the full input including the\nprefix). For input like \"192.168.1.999/24\", the error would show the\nfull string instead of just the invalid address part.\n\nFound by Coverity (CID: COPY_PASTE_ERROR).\n\nFixes: 539db43619e4 ('libnm: avoid heap allocation for checking valid routes in nm_ip_route_attribute_validate()')\n\nCo-Authored-By: Claude Opus 4.6 \n","title":"libnm: fix wrong variable in route attribute validation error message","timestamp":"2026-04-14T12:54:12+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/3d4ad7b4ba33a067396acb4a81f78273ada88b9a","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-setting-ip-config.c"],"removed":[]},{"id":"ca326bd636e642ef0c4916b8a0abaaacf13cd175","message":"libnm/tests: fix dead code in WireGuard roundtrip test\n\nThe inner condition at line 4086 duplicated the outer check for\nNM_CONNECTION_SERIALIZE_ALL, making the else-if branch for\nNM_CONNECTION_SERIALIZE_WITH_NON_SECRET unreachable. This meant\nthe non-secret serialization path was never actually tested.\n\nRestructure to make both branches reachable.\n\nFound by Coverity (CID: DEADCODE).\n\nFixes: 395a78618b6d ('libnm/tests: add tests for creating wireguard connection profiles')\n\nCo-Authored-By: Claude Opus 4.6 \n","title":"libnm/tests: fix dead code in WireGuard roundtrip test","timestamp":"2026-04-14T12:54:12+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/ca326bd636e642ef0c4916b8a0abaaacf13cd175","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/libnm-core-impl/tests/test-setting.c"],"removed":[]},{"id":"9303996b44bca8dd68796606b86efaae24e73d6c","message":"merge: branch 'jv/coverity'\n\ncoverity: fix bugs found by static analysis\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2394","title":"merge: branch 'jv/coverity'","timestamp":"2026-04-15T08:33:32+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9303996b44bca8dd68796606b86efaae24e73d6c","author":{"name":"Jan Vaclav","email":"jvaclav@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c","src/core/dns/nm-dns-manager.c","src/core/nm-policy.c","src/libnm-core-impl/nm-setting-ip-config.c","src/libnm-core-impl/tests/test-setting.c","src/nm-initrd-generator/nmi-cmdline-reader.c","src/nmtui/nmt-wireguard-peer-list.c"],"removed":[]}],"total_commits_count":8,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}