{"object_kind":"push","event_name":"push","before":"0af2c65861c0390afa383143deb3796439b8c340","after":"a1518ad6c2c75ef4d05ac071f36a0455ef3e7a68","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"a1518ad6c2c75ef4d05ac071f36a0455ef3e7a68","message":null,"user_id":1050,"user_name":"Beniamino Galvani","user_username":"bgalvani","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1050/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"e86ba908b20f3cfe696ff7a69cc5ddc2a371899b","message":"device: fix IPv4 forwarding not enabled on modem data interfaces\n\nModem devices implement ready_for_ip_config() to skip the standard IP\nmethods (DHCP, shared, link-local) since they handle IP configuration\nvia ModemManager bearers.\n\nThis also skipped _dev_ipforwarding4_start(), which is responsible for:\n\n - Enabling forwarding when needed, e.g. when ipv4.method=shared is\n   active elsewhere.\n\n - Connecting to the SHARING_IPV4_CHANGED signal so forwarding can be\n   retroactively enabled when a shared connection appears later.\n\nAs a result, when using a modem as the upstream connection and a Wi-Fi\nhotspot (ipv4.method=shared), forwarding was not enabled on the\nmodem's data interface (e.g. qmapmux0.0), breaking IPv4 connection\nsharing.\n\nFix this by moving _dev_ipforwarding4_start() to the out_devip label\nso it runs for all device types that have an IP ifindex, including\nthose that skip standard IP methods.\n\nGuard with an ifindex check so devices that don't yet have a kernel\nlink (like OVS internal interfaces) are not affected.\n\nFixes: 32cbf4c629a3 ('ip: shared: stop using the global forwarding')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/work_items/1935\nhttps://gitlab.postmarketos.org/postmarketOS/pmaports/-/work_items/4118\n","title":"device: fix IPv4 forwarding not enabled on modem data interfaces","timestamp":"2026-07-21T09:02:25+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/e86ba908b20f3cfe696ff7a69cc5ddc2a371899b","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"a1518ad6c2c75ef4d05ac071f36a0455ef3e7a68","message":"merge: branch 'bg/modem-fix-ipv4-forwarding'\n\ndevice: fix IPv4 forwarding not enabled on modem data interfaces\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2469","title":"merge: branch 'bg/modem-fix-ipv4-forwarding'","timestamp":"2026-07-21T09:39:15+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/a1518ad6c2c75ef4d05ac071f36a0455ef3e7a68","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]}],"total_commits_count":2,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}