{"object_kind":"push","event_name":"push","before":"746a32ca7aaba2d717fa2848c47f22e4f9612d08","after":"4b63ae29a5c030c9a5cd199b546da3d7a1331827","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"4b63ae29a5c030c9a5cd199b546da3d7a1331827","message":null,"user_id":1050,"user_name":"Beniamino Galvani","user_username":"bgalvani","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1050/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"0246862ab8f9d8a716ab286ee57ca2d42cce2404","message":"libnm-glib-aux: don't undefine GLib macros\n\nNetworkManager defines its own NM_MIN()/NM_MAX() macros which offer\nsome advantages over the MIN()/MAX() from GLib: arguments are\nevaluated only once and mixed signed/unsigned comparisons are\nrejected, while still preserving compile time evaluation for constant\nvalues.\n\nTo prevent the usage of the GLib macros, they were undefined in\nnm-glib.h. However, this can cause compilation errors if the public\nGLib headers use them:\n\n  /usr/include/glib-2.0/glib/gslice.h:48:57: error: implicit declaration of function ‘MAX’ [-Wimplicit-function-declaration]\n     48 | #define  g_slice_new(type)      ((type*) g_slice_alloc (MAX (sizeof (type), 1)))\n      |                                                         ^~~\n  ../src/libnm-glib-aux/nm-dbus-aux.c:652:23: note: in expansion of macro ‘g_slice_new’\n    652 |     sd              = g_slice_new(NMDBusSignalData);\n        |                       ^~~~~~~~~~~\n\nDon't undefine the macros but add checkpatch rules to verify the NM\nvariants are used. Use a similar approach for other macros.\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/work_items/1911\n","title":"libnm-glib-aux: don't undefine GLib macros","timestamp":"2026-07-21T10:04:29+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/0246862ab8f9d8a716ab286ee57ca2d42cce2404","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["contrib/scripts/checkpatch.pl","src/libnm-glib-aux/nm-glib.h"],"removed":[]},{"id":"3fbe03b1d842453a1f2b23fdc0c41c02432ba2fd","message":"all: use NM_CLAMP() instead of CLAMP()\n","title":"all: use NM_CLAMP() instead of CLAMP()","timestamp":"2026-07-21T10:04:29+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/3fbe03b1d842453a1f2b23fdc0c41c02432ba2fd","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/nm-core-utils.c","src/core/platform/tests/test-common.c","src/core/supplicant/nm-supplicant-config.c","src/core/supplicant/nm-supplicant-interface.c","src/libnm-platform/wifi/nm-wifi-utils-nl80211.c","src/libnm-platform/wifi/nm-wifi-utils-wext.c","src/libnmt-newt/nmt-newt-popup.c"],"removed":[]},{"id":"4b63ae29a5c030c9a5cd199b546da3d7a1331827","message":"merge: branch 'bg/min-max-macros'\n\nlibnm-glib-aux: don't undefine GLib macros\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2471","title":"merge: branch 'bg/min-max-macros'","timestamp":"2026-07-21T10:58:41+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/4b63ae29a5c030c9a5cd199b546da3d7a1331827","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["contrib/scripts/checkpatch.pl","src/core/nm-core-utils.c","src/core/platform/tests/test-common.c","src/core/supplicant/nm-supplicant-config.c","src/core/supplicant/nm-supplicant-interface.c","src/libnm-glib-aux/nm-glib.h","src/libnm-platform/wifi/nm-wifi-utils-nl80211.c","src/libnm-platform/wifi/nm-wifi-utils-wext.c","src/libnmt-newt/nmt-newt-popup.c"],"removed":[]}],"total_commits_count":3,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}