{"object_kind":"push","event_name":"push","before":"a7c187a35e5d74f541b05d89ffe524e79f78942b","after":"f6857161e1c93cbe7ba1b17078c489fa7d7b3b72","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"f6857161e1c93cbe7ba1b17078c489fa7d7b3b72","message":null,"user_id":1266450,"user_name":"Madhav V","user_username":"mad6av","user_email":"[REDACTED]","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1266450/avatar.png?v=1793074249","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png?v=1793074321","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"b0772b187b92756f6018a1eba863eef3ce85fc21","message":"vpn: remove hint prefixes before storing\n\nNetworkManager could crash when a VPN secret arrive over dbus\nwith a dynamic-challenge prefix.\n\n- `vpn_secrets_from_dbus` function would insert the raw,\n  still-prefixed string directly into the in-memory secrets\n  dictionary (`priv->secrets`)\n- The parser kept the prefix in the in-memory secrets dictionary,\n  causing `nm_setting_get_secret_flags()` (called by\n  eg: `write_hash_of_string()`) to strip the prefix again at lookup\n  time, then fail to find either the derived flags key or\n  the secret itself, returning FALSE and triggering an assertion at\n  the caller.\n\nThis fix adds a new helper `_process_secret_hint` which ensures the\nprefix is stripped from the secret key before it is inserted into the\nin-memory secrets dictionary and automatically merges any\n`hint_implied_flags` into the secret's existing flags. It also rejects\nempty or double prefixed hint tags.\n\nSame fix is applied to `update_secret_string()` and\n`update_secret_dict()` paths.\n\nThis change also skips tagged flag keys in `aggregate()` to prevent\ndaemon aborts caused by assertion failures when resolving hinted VPN\nsecret-names during activation.\n\nResolves: https://redhat.atlassian.net/browse/RHEL-220661\nFixes: 0583e1f8436e ('vpn: handle hint tags in the daemon')\n","title":"vpn: remove hint prefixes before storing","timestamp":"2026-10-27T04:12:01+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/b0772b187b92756f6018a1eba863eef3ce85fc21","author":{"name":"Madhav V","email":"mav@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-setting-vpn.c","src/libnm-core-impl/tests/test-general.c"],"removed":[]},{"id":"f6857161e1c93cbe7ba1b17078c489fa7d7b3b72","message":"merge: branch 'fix/vpn-secret-hint-normalization'\n\nvpn: remove hint prefixes before storing.\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2561","title":"merge: branch 'fix/vpn-secret-hint-normalization'","timestamp":"2026-10-27T04:45:49+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/f6857161e1c93cbe7ba1b17078c489fa7d7b3b72","author":{"name":"Madhav V","email":"mav@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-setting-vpn.c","src/libnm-core-impl/tests/test-general.c"],"removed":[]}],"total_commits_count":2,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}