This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0", "*No copyright* GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]". 17 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/repo/licensecheck.txt [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define beta %{nil}, %define scmrev %{nil}, %define is_opensuse %(if echo "%{?dist}" |grep -q suse; then echo 1; else echo 0; fi) [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: repo-2.10-1.fc35.noarch.rpm repo-2.10-1.fc35.src.rpm repo.noarch: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce repo.noarch: E: no-changelogname-tag repo.noarch: W: invalid-license Apache Software License repo.noarch: W: no-url-tag repo.noarch: W: no-documentation repo.noarch: E: incorrect-fsf-address /usr/share/repo/hooks/pre-auto-gc repo.noarch: W: no-manual-page-for-binary repo repo.src: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce repo.src: E: no-changelogname-tag repo.src: W: invalid-license Apache Software License repo.src: W: no-url-tag repo.src:12: W: macro-in-comment %{version} repo.src:12: W: macro-in-comment %{version} repo.src:12: W: macro-in-comment %{version} repo.src:13: W: macro-in-comment %{version} repo.src:49: E: hardcoded-library-path in %{_prefix}/lib/python*/site-packages/repo* repo.src: E: specfile-error warning: Macro expanded in comment on line 12: %{version}.tar --prefix repo-%{version}/ v%{version} repo.src: E: specfile-error repo.src: E: specfile-error warning: Macro expanded in comment on line 13: %{version}.tar repo.src: E: specfile-error repo.src: E: specfile-error warning: Macro expanded in comment on line 12: %{version}.tar --prefix repo-%{version}/ v%{version} repo.src: E: specfile-error repo.src: E: specfile-error warning: Macro expanded in comment on line 13: %{version}.tar 2 packages and 0 specfiles checked; 11 errors, 12 warnings. Rpmlint (installed packages) ---------------------------- repo.noarch: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce repo.noarch: E: no-changelogname-tag repo.noarch: W: invalid-license Apache Software License repo.noarch: W: no-url-tag repo.noarch: W: no-documentation repo.noarch: E: incorrect-fsf-address /usr/share/repo/hooks/pre-auto-gc repo.noarch: W: no-manual-page-for-binary repo 1 packages and 0 specfiles checked; 2 errors, 5 warnings. Requires -------- repo (rpmlib, GLIBC filtered): /usr/bin/python3 /usr/bin/sh git gnupg python3 Provides -------- repo: repo Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name repo --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-i686 Active plugins: Generic, Shell-api Disabled plugins: Ocaml, Haskell, PHP, fonts, C/C++, SugarActivity, Java, Perl, R, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH