This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: llama.cpp-b2060-1.fc40.x86_64.rpm llama.cpp-devel-b2060-1.fc40.x86_64.rpm llama.cpp-debuginfo-b2060-1.fc40.x86_64.rpm llama.cpp-debugsource-b2060-1.fc40.x86_64.rpm llama.cpp-b2060-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpzbx4m7mq')] checks: 31, packages: 5 llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/baby-llama llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/batched llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/batched-bench llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/beam-search llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/benchmark llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/convert-llama2c-to-ggml llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/embedding llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/export-lora llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/finetune llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/imatrix llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/infill llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/llama-bench llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/llava-cli llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/lookahead llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/lookup llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/main llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/parallel llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/passkey llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/perplexity llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/quantize llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/quantize-stats llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/save-load-state llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/server llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/simple llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/speculative llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/test-autorelease llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/test-backend-ops llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/test-grad0 llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/test-grammar-parser llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/test-llama-grammar llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/test-model-load-cancel llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/test-quantize-fns llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/test-quantize-perf llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/test-rope llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/test-sampling llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/test-tokenizer-0-falcon llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/test-tokenizer-0-llama llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/test-tokenizer-1-bpe llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/test-tokenizer-1-llama llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/tokenize llama.cpp.x86_64: W: position-independent-executable-suggested /usr/bin/train-text-from-scratch llama.cpp-devel.x86_64: W: only-non-binary-in-usr-lib llama.cpp.x86_64: W: no-manual-page-for-binary baby-llama llama.cpp.x86_64: W: no-manual-page-for-binary batched llama.cpp.x86_64: W: no-manual-page-for-binary batched-bench llama.cpp.x86_64: W: no-manual-page-for-binary beam-search llama.cpp.x86_64: W: no-manual-page-for-binary benchmark llama.cpp.x86_64: W: no-manual-page-for-binary convert-llama2c-to-ggml llama.cpp.x86_64: W: no-manual-page-for-binary convert-lora-to-ggml.py llama.cpp.x86_64: W: no-manual-page-for-binary convert.py llama.cpp.x86_64: W: no-manual-page-for-binary embedding llama.cpp.x86_64: W: no-manual-page-for-binary export-lora llama.cpp.x86_64: W: no-manual-page-for-binary finetune llama.cpp.x86_64: W: no-manual-page-for-binary imatrix llama.cpp.x86_64: W: no-manual-page-for-binary infill llama.cpp.x86_64: W: no-manual-page-for-binary llama-bench llama.cpp.x86_64: W: no-manual-page-for-binary llava-cli llama.cpp.x86_64: W: no-manual-page-for-binary lookahead llama.cpp.x86_64: W: no-manual-page-for-binary lookup llama.cpp.x86_64: W: no-manual-page-for-binary main llama.cpp.x86_64: W: no-manual-page-for-binary parallel llama.cpp.x86_64: W: no-manual-page-for-binary passkey llama.cpp.x86_64: W: no-manual-page-for-binary perplexity llama.cpp.x86_64: W: no-manual-page-for-binary quantize llama.cpp.x86_64: W: no-manual-page-for-binary quantize-stats llama.cpp.x86_64: W: no-manual-page-for-binary save-load-state llama.cpp.x86_64: W: no-manual-page-for-binary server llama.cpp.x86_64: W: no-manual-page-for-binary simple llama.cpp.x86_64: W: no-manual-page-for-binary speculative llama.cpp.x86_64: W: no-manual-page-for-binary test-autorelease llama.cpp.x86_64: W: no-manual-page-for-binary test-backend-ops llama.cpp.x86_64: W: no-manual-page-for-binary test-grad0 llama.cpp.x86_64: W: no-manual-page-for-binary test-grammar-parser llama.cpp.x86_64: W: no-manual-page-for-binary test-llama-grammar llama.cpp.x86_64: W: no-manual-page-for-binary test-model-load-cancel llama.cpp.x86_64: W: no-manual-page-for-binary test-quantize-fns llama.cpp.x86_64: W: no-manual-page-for-binary test-quantize-perf llama.cpp.x86_64: W: no-manual-page-for-binary test-rope llama.cpp.x86_64: W: no-manual-page-for-binary test-sampling llama.cpp.x86_64: W: no-manual-page-for-binary test-tokenizer-0-falcon llama.cpp.x86_64: W: no-manual-page-for-binary test-tokenizer-0-llama llama.cpp.x86_64: W: no-manual-page-for-binary test-tokenizer-1-bpe llama.cpp.x86_64: W: no-manual-page-for-binary test-tokenizer-1-llama llama.cpp.x86_64: W: no-manual-page-for-binary tokenize llama.cpp.x86_64: W: no-manual-page-for-binary train-text-from-scratch llama.cpp.x86_64: W: no-documentation llama.cpp-devel.x86_64: W: no-documentation llama.cpp.spec:36: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 36) llama.cpp.spec:49: W: macro-in-comment %cmake_test llama.cpp.x86_64: E: invalid-soname /usr/lib64/libggml_shared.so libggml_shared.so llama.cpp.x86_64: E: invalid-soname /usr/lib64/libllama.so libllama.so llama.cpp.x86_64: E: invalid-soname /usr/lib64/libllava_shared.so libllava_shared.so 5 packages and 0 specfiles checked; 3 errors, 89 warnings, 3 badness; has taken 3.2 s Rpmlint (debuginfo) ------------------- Checking: llama.cpp-debuginfo-b2060-1.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpspintdzf')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.9 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "llama.cpp-debuginfo". (none): E: there is no installed rpm "llama.cpp". (none): E: there is no installed rpm "llama.cpp-devel". (none): E: there is no installed rpm "llama.cpp-debugsource". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Unversioned so-files -------------------- llama.cpp: /usr/lib64/libggml_shared.so llama.cpp: /usr/lib64/libllama.so llama.cpp: /usr/lib64/libllava_shared.so Source checksums ---------------- https://github.com/ggerganov/llama.cpp/archive/b2060/llama.cpp-b2060.tar.gz : CHECKSUM(SHA256) this package : b970126df27d06d700b1a54fdc73f924fc97ab7990a38b31da9be5671c0410e7 CHECKSUM(SHA256) upstream package : b970126df27d06d700b1a54fdc73f924fc97ab7990a38b31da9be5671c0410e7 Requires -------- llama.cpp (rpmlib, GLIBC filtered): /usr/bin/python3 ld-linux-x86-64.so.2()(64bit) libOpenCL.so.1()(64bit) libOpenCL.so.1(OPENCL_1.0)(64bit) libOpenCL.so.1(OPENCL_1.1)(64bit) libOpenCL.so.1(OPENCL_1.2)(64bit) libc.so.6()(64bit) libclblast.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libllama.so()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) rtld(GNU_HASH) llama.cpp-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) llama.cpp(x86-64) llama.cpp-debuginfo (rpmlib, GLIBC filtered): llama.cpp-debugsource (rpmlib, GLIBC filtered): Provides -------- llama.cpp: libggml_shared.so()(64bit) libllama.so()(64bit) libllava_shared.so()(64bit) llama.cpp llama.cpp(x86-64) llama.cpp-devel: cmake(Llama) cmake(llama) llama.cpp-devel llama.cpp-devel(x86-64) llama.cpp-debuginfo: debuginfo(build-id) libggml_shared.so-b2060-1.fc40.x86_64.debug()(64bit) libllama.so-b2060-1.fc40.x86_64.debug()(64bit) libllava_shared.so-b2060-1.fc40.x86_64.debug()(64bit) llama.cpp-debuginfo llama.cpp-debuginfo(x86-64) llama.cpp-debugsource: llama.cpp-debugsource llama.cpp-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name llama.cpp --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, Perl, Ocaml, R, fonts, SugarActivity, PHP, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH