This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "PostgreSQL License", "*No copyright* PostgreSQL License", "*No copyright* Apache License 2.0", "MIT License", "BSD 0-Clause License", "*No copyright* MIT License", "*No copyright* The Unlicense", "Apache License 2.0", "*No copyright* Apache License (v2.0) or MIT license and/or MIT License", "Apache License 2.0 and/or MIT License", "BSD 2-Clause License", "BSD 3-Clause License", "*No copyright* Apache License (v2.0) or MIT license", "zlib License", "*No copyright* zlib License", "Apache License (v2.0) or MIT license", "*No copyright* Creative Commons CC0 1.0", "*No copyright* MIT No Attribution", "*No copyright* BSD 3-Clause License and/or Creative Commons Attribution 3.0 and/or MIT License", "ISC License", "Unicode License Agreement - Data Files and Software (2016)", "*No copyright* Apache License 2.0 and/or MIT License", "*No copyright* Boost Software License 1.0", "*No copyright* Apache License 2.0 and/or MIT License and/or zlib License", "Apache License 2.0 and/or BSD 3-Clause License", "*No copyright* SIL Open Font License", "Apache License 2.0 and/or GNU Lesser General Public License v2.1 or later and/or MIT License", "Apple Public Source License 2.0", "BSD 3-Clause License and/or MIT License", "*No copyright* Mozilla Public License 2.0", "*No copyright* Public domain", "Apache License (v2.0) or MIT license and/or MIT License", "*No copyright* Apache License 2.0 and/or Public domain", "*No copyright* BSD 0-Clause License", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 2.1", "FSF All Permissive License", "Apache License 2.0 [generated file]", "*No copyright* ISC License", "Apache License 2.0 and/or Boost Software License 1.0", "BSD 3-Clause License [generated file]", "BSD 2-Clause with views sentence", "GNU General Public License v2.0 or later", "GNU Lesser General Public License v2.1 or later", "*No copyright* GNU General Public License, Version 3", "FSF Unlimited License (with License Retention)", "FSF Unlimited License", "Public domain", "*No copyright* GNU General Public License, Version 2", "*No copyright* BSD 0-Clause License [generated file]". 29039 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/postgresql16-anonymizer/licensecheck.txt [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 117448 bytes in 4 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: postgresql16-anonymizer-2.3.0-1.fc44.aarch64.rpm postgresql16-anonymizer-2.3.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpgcgbbf2h')] checks: 32, packages: 2 postgresql16-anonymizer.spec:110: W: unversioned-explicit-provides %{extension}-any postgresql16-anonymizer.src: W: strange-permission anonymizer-cargo.patch 666 postgresql16-anonymizer.src: W: strange-permission create-vendored-tarball.sh 777 postgresql16-anonymizer.src: W: strange-permission postgresql16-anonymizer.spec 666 postgresql16-anonymizer.src: W: strange-permission postgresql_anonymizer-2.3.0-vendored.tar.xz 666 postgresql16-anonymizer.src: W: strange-permission postgresql_anonymizer-2.3.0.tar.gz 666 postgresql16-anonymizer.aarch64: E: spelling-error ('anonymization', '%description -l en_US anonymization -> randomization, canonization, minimization') postgresql16-anonymizer.src: E: spelling-error ('anonymization', '%description -l en_US anonymization -> randomization, canonization, minimization') postgresql16-anonymizer.spec: W: no-%check-section postgresql16-anonymizer.spec: W: invalid-url Source1: postgresql_anonymizer-2.3.0-vendored.tar.xz 2 packages and 0 specfiles checked; 2 errors, 8 warnings, 7 filtered, 2 badness; has taken 2.4 s Rpmlint (debuginfo) ------------------- Checking: postgresql16-anonymizer-debuginfo-2.3.0-1.fc44.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfu76nb5c')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 2.8 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "postgresql16-anonymizer-debuginfo". (none): E: there is no installed rpm "postgresql16-anonymizer". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Unversioned so-files -------------------- postgresql16-anonymizer: /usr/lib64/pgsql/anon.so Source checksums ---------------- https://gitlab.com/dalibo/postgresql_anonymizer/-/archive/2.3.0/postgresql_anonymizer-2.3.0.tar.gz : CHECKSUM(SHA256) this package : 95de7cfd271ee69f37b596d38fd280d69df5e252f4bcd57347017c08a8df122d CHECKSUM(SHA256) upstream package : 95de7cfd271ee69f37b596d38fd280d69df5e252f4bcd57347017c08a8df122d Requires -------- postgresql16-anonymizer (rpmlib, GLIBC filtered): ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) postgresql16-server rtld(GNU_HASH) Provides -------- postgresql16-anonymizer: bundled(crate(adler2)) bundled(crate(aho-corasick)) bundled(crate(aligned-vec)) bundled(crate(allocator-api2)) bundled(crate(android-tzdata)) bundled(crate(android_system_properties)) bundled(crate(annotate-snippets)) bundled(crate(anstyle)) bundled(crate(anyhow)) bundled(crate(arbitrary)) bundled(crate(arg_enum_proc_macro)) bundled(crate(arrayvec)) bundled(crate(atomic)) bundled(crate(atomic-traits)) bundled(crate(autocfg)) bundled(crate(av1-grain)) bundled(crate(avif-serialize)) bundled(crate(bigdecimal)) bundled(crate(bindgen)) bundled(crate(bit_field)) bundled(crate(bitflags)) bundled(crate(bitstream-io)) bundled(crate(bitvec)) bundled(crate(block-buffer)) bundled(crate(built)) bundled(crate(bumpalo)) bundled(crate(bytemuck)) bundled(crate(byteorder)) bundled(crate(byteorder-lite)) bundled(crate(bytes)) bundled(crate(c_str_macro)) bundled(crate(cargo_toml)) bundled(crate(cc)) bundled(crate(cee-scape)) bundled(crate(cexpr)) bundled(crate(cfg-expr)) bundled(crate(cfg-if)) bundled(crate(chrono)) bundled(crate(clang-sys)) bundled(crate(color_quant)) bundled(crate(convert_case)) bundled(crate(core-foundation-sys)) bundled(crate(crc32fast)) bundled(crate(crossbeam-deque)) bundled(crate(crossbeam-epoch)) bundled(crate(crossbeam-utils)) bundled(crate(crunchy)) bundled(crate(crypto-common)) bundled(crate(deranged)) bundled(crate(deunicode)) bundled(crate(digest)) bundled(crate(displaydoc)) bundled(crate(either)) bundled(crate(enum-map)) bundled(crate(enum-map-derive)) bundled(crate(equator)) bundled(crate(equator-macro)) bundled(crate(equivalent)) bundled(crate(exr)) bundled(crate(eyre)) bundled(crate(fake)) bundled(crate(fastrand)) bundled(crate(fdeflate)) bundled(crate(fixedbitset)) bundled(crate(flate2)) bundled(crate(fnv)) bundled(crate(foldhash)) bundled(crate(form_urlencoded)) bundled(crate(funty)) bundled(crate(generic-array)) bundled(crate(getrandom)) bundled(crate(gif)) bundled(crate(glob)) bundled(crate(half)) bundled(crate(hash32)) bundled(crate(hashbrown)) bundled(crate(heapless)) bundled(crate(heck)) bundled(crate(hermit-abi)) bundled(crate(home)) bundled(crate(http)) bundled(crate(iana-time-zone)) bundled(crate(iana-time-zone-haiku)) bundled(crate(icu_collections)) bundled(crate(icu_locale_core)) bundled(crate(icu_normalizer)) bundled(crate(icu_normalizer_data)) bundled(crate(icu_properties)) bundled(crate(icu_properties_data)) bundled(crate(icu_provider)) bundled(crate(idna)) bundled(crate(idna_adapter)) bundled(crate(image)) bundled(crate(image-webp)) bundled(crate(imgref)) bundled(crate(indenter)) bundled(crate(indexmap)) bundled(crate(interpolate_name)) bundled(crate(is-terminal)) bundled(crate(is_ci)) bundled(crate(itertools)) bundled(crate(itoa)) bundled(crate(jobserver)) bundled(crate(jpeg-decoder)) bundled(crate(js-sys)) bundled(crate(lebe)) bundled(crate(libc)) bundled(crate(libfuzzer-sys)) bundled(crate(libloading)) bundled(crate(libm)) bundled(crate(litemap)) bundled(crate(log)) bundled(crate(loop9)) bundled(crate(maybe-rayon)) bundled(crate(md-5)) bundled(crate(memchr)) bundled(crate(minimal-lexical)) bundled(crate(miniz_oxide)) bundled(crate(new_debug_unreachable)) bundled(crate(nom)) bundled(crate(noop_proc_macro)) bundled(crate(num-bigint)) bundled(crate(num-conv)) bundled(crate(num-derive)) bundled(crate(num-integer)) bundled(crate(num-rational)) bundled(crate(num-traits)) bundled(crate(once_cell)) bundled(crate(owo-colors)) bundled(crate(paste)) bundled(crate(pathsearch)) bundled(crate(percent-encoding)) bundled(crate(petgraph)) bundled(crate(pgrx)) bundled(crate(pgrx-bindgen)) bundled(crate(pgrx-macros)) bundled(crate(pgrx-pg-config)) bundled(crate(pgrx-pg-sys)) bundled(crate(pgrx-sql-entity-graph)) bundled(crate(pkg-config)) bundled(crate(png)) bundled(crate(potential_utf)) bundled(crate(powerfmt)) bundled(crate(ppv-lite86)) bundled(crate(proc-macro2)) bundled(crate(profiling)) bundled(crate(profiling-procmacros)) bundled(crate(qoi)) bundled(crate(quick-error)) bundled(crate(quote)) bundled(crate(r-efi)) bundled(crate(radium)) bundled(crate(rand)) bundled(crate(rand_chacha)) bundled(crate(rand_core)) bundled(crate(random_color)) bundled(crate(rav1e)) bundled(crate(ravif)) bundled(crate(rayon)) bundled(crate(rayon-core)) bundled(crate(regex)) bundled(crate(regex-automata)) bundled(crate(regex-syntax)) bundled(crate(rgb)) bundled(crate(rust_decimal)) bundled(crate(rustc-hash)) bundled(crate(rustc_version)) bundled(crate(rustversion)) bundled(crate(ryu)) bundled(crate(same-file)) bundled(crate(seahash)) bundled(crate(semver)) bundled(crate(serde)) bundled(crate(serde_cbor)) bundled(crate(serde_derive)) bundled(crate(serde_json)) bundled(crate(serde_spanned)) bundled(crate(sha1_smol)) bundled(crate(shlex)) bundled(crate(simd-adler32)) bundled(crate(simd_helpers)) bundled(crate(smallvec)) bundled(crate(sptr)) bundled(crate(stable_deref_trait)) bundled(crate(supports-color)) bundled(crate(syn)) bundled(crate(synstructure)) bundled(crate(system-deps)) bundled(crate(tap)) bundled(crate(target-lexicon)) bundled(crate(thiserror)) bundled(crate(thiserror-impl)) bundled(crate(tiff)) bundled(crate(time)) bundled(crate(time-core)) bundled(crate(tinystr)) bundled(crate(toml)) bundled(crate(toml_datetime)) bundled(crate(toml_edit)) bundled(crate(toml_write)) bundled(crate(typenum)) bundled(crate(unescape)) bundled(crate(unicode-ident)) bundled(crate(unicode-segmentation)) bundled(crate(unicode-width)) bundled(crate(url)) bundled(crate(url-escape)) bundled(crate(utf8_iter)) bundled(crate(uuid)) bundled(crate(v_frame)) bundled(crate(version-compare)) bundled(crate(version_check)) bundled(crate(walkdir)) bundled(crate(wasi)) bundled(crate(wasm-bindgen)) bundled(crate(wasm-bindgen-backend)) bundled(crate(wasm-bindgen-macro)) bundled(crate(wasm-bindgen-macro-support)) bundled(crate(wasm-bindgen-shared)) bundled(crate(weezl)) bundled(crate(winapi-util)) bundled(crate(windows-core)) bundled(crate(windows-implement)) bundled(crate(windows-interface)) bundled(crate(windows-link)) bundled(crate(windows-result)) bundled(crate(windows-strings)) bundled(crate(windows-sys)) bundled(crate(windows-targets)) bundled(crate(windows_aarch64_gnullvm)) bundled(crate(windows_aarch64_msvc)) bundled(crate(windows_i686_gnu)) bundled(crate(windows_i686_gnullvm)) bundled(crate(windows_i686_msvc)) bundled(crate(windows_x86_64_gnu)) bundled(crate(windows_x86_64_gnullvm)) bundled(crate(windows_x86_64_msvc)) bundled(crate(winnow)) bundled(crate(wit-bindgen-rt)) bundled(crate(writeable)) bundled(crate(wyz)) bundled(crate(yoke)) bundled(crate(yoke-derive)) bundled(crate(zerocopy)) bundled(crate(zerocopy-derive)) bundled(crate(zerofrom)) bundled(crate(zerofrom-derive)) bundled(crate(zerotrie)) bundled(crate(zerovec)) bundled(crate(zerovec-derive)) bundled(crate(zune-core)) bundled(crate(zune-inflate)) bundled(crate(zune-jpeg)) postgresql16-anonymizer postgresql16-anonymizer(aarch-64) postgresql_anonymizer-any Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name postgresql16-anonymizer --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: PHP, SugarActivity, fonts, Ocaml, Python, R, Java, Perl, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH