class RuboCop::Cop::Style::CombinableLoops
Checks for places where multiple consecutive loops over the same data can be combined into a single loop. It is very likely that combining them will make the code more efficient and more concise.
@safety
The cop is unsafe, because the first loop might modify state that the second loop depends on; these two aren't combinable.
@example
# bad def method items.each do |item| do_something(item) end items.each do |item| do_something_else(item) end end # good def method items.each do |item| do_something(item) do_something_else(item) end end # bad def method for item in items do do_something(item) end for item in items do do_something_else(item) end end # good def method for item in items do do_something(item) do_something_else(item) end end # good def method each_slice(2) { |slice| do_something(slice) } each_slice(3) { |slice| do_something(slice) } end
Constants
- MSG
Public Instance Methods
on_block(node)
click to toggle source
# File lib/rubocop/cop/style/combinable_loops.rb, line 62 def on_block(node) return unless node.parent&.begin_type? return unless collection_looping_method?(node) add_offense(node) if same_collection_looping?(node, node.left_sibling) end
Also aliased as: on_numblock
on_for(node)
click to toggle source
# File lib/rubocop/cop/style/combinable_loops.rb, line 71 def on_for(node) return unless node.parent&.begin_type? sibling = node.left_sibling add_offense(node) if sibling&.for_type? && node.collection == sibling.collection end
Private Instance Methods
collection_looping_method?(node)
click to toggle source
# File lib/rubocop/cop/style/combinable_loops.rb, line 80 def collection_looping_method?(node) # TODO: Remove `Symbol#to_s` after supporting only Ruby >= 2.7. method_name = node.method_name.to_s method_name.start_with?('each') || method_name.end_with?('_each') end
same_collection_looping?(node, sibling)
click to toggle source
# File lib/rubocop/cop/style/combinable_loops.rb, line 86 def same_collection_looping?(node, sibling) (sibling&.block_type? || sibling&.numblock_type?) && sibling.send_node.method?(node.method_name) && sibling.receiver == node.receiver && sibling.send_node.arguments == node.send_node.arguments end