This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPLv2 or Ruby or BSD'. It seems that you are using the old Fedora license abbreviations. Try `license- fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rubygem-highline See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: When checking ruby code, install the ruby plugin. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: rubygem-highline-2.0.3-6.fc39.noarch.rpm rubygem-highline-doc-2.0.3-6.fc39.noarch.rpm rubygem-highline-2.0.3-6.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmps3z5323e')] checks: 31, packages: 3 rubygem-highline-doc.noarch: E: non-executable-script /usr/share/gems/gems/highline-2.0.3/examples/ansi_colors.rb 644 /usr/bin/env ruby rubygem-highline-doc.noarch: E: non-executable-script /usr/share/gems/gems/highline-2.0.3/examples/asking_for_arrays.rb 644 /usr/bin/env ruby rubygem-highline-doc.noarch: E: non-executable-script /usr/share/gems/gems/highline-2.0.3/examples/basic_usage.rb 644 /usr/bin/env ruby rubygem-highline-doc.noarch: E: non-executable-script /usr/share/gems/gems/highline-2.0.3/examples/color_scheme.rb 644 /usr/bin/env ruby -w rubygem-highline-doc.noarch: E: non-executable-script /usr/share/gems/gems/highline-2.0.3/examples/get_character.rb 644 /usr/bin/env ruby rubygem-highline-doc.noarch: E: non-executable-script /usr/share/gems/gems/highline-2.0.3/examples/limit.rb 644 /usr/bin/env ruby -w rubygem-highline-doc.noarch: E: non-executable-script /usr/share/gems/gems/highline-2.0.3/examples/menus.rb 644 /usr/bin/env ruby rubygem-highline-doc.noarch: E: non-executable-script /usr/share/gems/gems/highline-2.0.3/examples/overwrite.rb 644 /usr/bin/env ruby rubygem-highline-doc.noarch: E: non-executable-script /usr/share/gems/gems/highline-2.0.3/examples/page_and_wrap.rb 644 /usr/bin/env ruby rubygem-highline-doc.noarch: E: non-executable-script /usr/share/gems/gems/highline-2.0.3/examples/password.rb 644 /usr/bin/env ruby rubygem-highline-doc.noarch: E: non-executable-script /usr/share/gems/gems/highline-2.0.3/examples/repeat_entry.rb 644 /usr/bin/env ruby rubygem-highline-doc.noarch: E: non-executable-script /usr/share/gems/gems/highline-2.0.3/examples/trapping_eof.rb 644 /usr/bin/env ruby rubygem-highline-doc.noarch: E: non-executable-script /usr/share/gems/gems/highline-2.0.3/examples/using_readline.rb 644 /usr/bin/env ruby rubygem-highline.noarch: W: no-documentation rubygem-highline.spec:47: W: mixed-use-of-spaces-and-tabs (spaces: line 47, tab: line 14) rubygem-highline.spec: W: invalid-url Source1: tests-2.0.3.tar.bz2 3 packages and 0 specfiles checked; 13 errors, 3 warnings, 13 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "rubygem-highline-doc". (none): E: there is no installed rpm "rubygem-highline". There are no files to process nor additional arguments. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Nothing to do, aborting. Source checksums ---------------- https://rubygems.org/gems/highline-2.0.3.gem : CHECKSUM(SHA256) this package : 2ddd5c127d4692721486f91737307236fe005352d12a4202e26c48614f719479 CHECKSUM(SHA256) upstream package : 2ddd5c127d4692721486f91737307236fe005352d12a4202e26c48614f719479 Requires -------- rubygem-highline (rpmlib, GLIBC filtered): ruby(rubygems) rubygem-highline-doc (rpmlib, GLIBC filtered): rubygem-highline Provides -------- rubygem-highline: rubygem(highline) rubygem-highline rubygem-highline-doc: rubygem-highline-doc Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rubygem-highline --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-aarch64 Active plugins: Generic, Shell-api Disabled plugins: R, Python, Perl, Ocaml, fonts, SugarActivity, Haskell, Java, PHP, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH