This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'BSD'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/lib/copr- rpmbuild/results/hpnssh/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in hpnssh-server See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/bin, /usr/src, /usr/lib/systemd, /usr/lib/systemd/user, /usr/src/debug, /etc/sysconfig, /usr/share/man/man1, /usr/share/man/man5, /usr/libexec, /usr, /usr/sbin, /usr/lib/systemd/system, /usr/lib, /usr/share, /etc/pam.d, /etc, /usr/lib/sysusers.d, /usr/share/licenses, /etc/profile.d, /usr/share/man/man8, /usr/share/man, /usr/share/doc [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/bin, /usr/src, /usr/lib/systemd, /usr/lib/systemd/user, /usr/src/debug, /etc/sysconfig, /usr/share/man/man1, /usr/share/man/man5, /usr/libexec, /usr, /usr/sbin, /usr/lib/systemd/system, /usr/lib, /usr/share, /etc/pam.d, /etc, /usr/lib/sysusers.d, /usr/share/licenses, /etc/profile.d, /usr/lib/.build-id/a9, /usr/share/man/man8, /usr/share/man, /usr/share/doc [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122268 bytes in 19 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Package uses hardened build flags if required to. Note: suid files: hpnssh-keysign [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Package contains systemd file(s) if in need. [x]: systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in hpnssh-clients [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make %{?_smp_mflags} macro. [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source1: https://github.com/rapier1/hpnssh- fedora/blob/main/SOURCES/hpnssh-9.7p1_hpn18.4.1.tar.gz.asc, Source0: https://github.com/rapier1/hpnssh- fedora/blob/main/SOURCES/hpnssh-9.7p1_hpn18.4.1.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in hpnssh- clients , hpnssh-server , hpnssh-keycat , hpnssh-askpass [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: Sources 2, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 16 and 17 are not passed to gpgverify. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /var/lib/copr-rpmbuild/results/hpnssh/srpm- unpacked/hpnssh.spec See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: hpnssh-9.7p1_hpn18.4.1-0.fc39.aarch64.rpm hpnssh-clients-9.7p1_hpn18.4.1-0.fc39.aarch64.rpm hpnssh-server-9.7p1_hpn18.4.1-0.fc39.aarch64.rpm hpnssh-keycat-9.7p1_hpn18.4.1-0.fc39.aarch64.rpm hpnssh-askpass-9.7p1_hpn18.4.1-0.fc39.aarch64.rpm hpnssh-debuginfo-9.7p1_hpn18.4.1-0.fc39.aarch64.rpm hpnssh-debugsource-9.7p1_hpn18.4.1-0.fc39.aarch64.rpm hpnssh-9.7p1_hpn18.4.1-0.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp4i5yqfva')] checks: 32, packages: 8 hpnssh.aarch64: E: spelling-error ('rlogin', '%description -l en_US rlogin -> login, r login, logging') hpnssh.aarch64: E: spelling-error ('rsh', '%description -l en_US rsh -> rah, rs, sh') hpnssh.aarch64: E: spelling-error ('untrusted', '%description -l en_US untrusted -> entrusted, trusted, encrusted') hpnssh.src: E: spelling-error ('rlogin', '%description -l en_US rlogin -> login, r login, logging') hpnssh.src: E: spelling-error ('rsh', '%description -l en_US rsh -> rah, rs, sh') hpnssh.src: E: spelling-error ('untrusted', '%description -l en_US untrusted -> entrusted, trusted, encrusted') hpnssh-keycat.aarch64: E: spelling-error ('mls', 'Summary(en_US) mls -> mks, ml, ms') hpnssh-keycat.aarch64: E: spelling-error ('openssh', 'Summary(en_US) openssh -> open ssh, open-ssh, opens sh') hpnssh-keycat.aarch64: E: spelling-error ('mls', '%description -l en_US mls -> mks, ml, ms') hpnssh-keycat.aarch64: E: spelling-error ('openssh', '%description -l en_US openssh -> open ssh, open-ssh, opens sh') hpnssh.aarch64: E: setuid-binary /usr/libexec/hpnssh/hpnssh-keysign root 4555 hpnssh.aarch64: W: obsolete-not-provided openssh-cavs hpnssh.aarch64: W: obsolete-not-provided openssh-ldap hpnssh.aarch64: W: non-standard-gid /usr/libexec/hpnssh/hpnssh-keysign ssh-keys hpnssh.aarch64: E: non-standard-executable-perm /usr/libexec/hpnssh/hpnssh-keysign 4555 hpnssh.aarch64: E: non-standard-executable-perm /usr/libexec/hpnssh/hpnssh-keysign 4555 hpnssh-server.aarch64: E: non-standard-dir-perm /usr/share/empty.hpnsshd 711 hpnssh-server.aarch64: E: non-readable /etc/hpnssh/sshd_config 600 hpnssh-server.aarch64: E: non-readable /etc/hpnssh/sshd_config.d/50-redhat.conf 600 hpnssh-server.aarch64: E: non-readable /etc/sysconfig/hpnsshd 640 hpnssh-askpass.aarch64: W: non-conffile-in-etc /etc/profile.d/gnome-hpnssh-askpass.csh hpnssh-askpass.aarch64: W: non-conffile-in-etc /etc/profile.d/gnome-hpnssh-askpass.sh hpnssh-askpass.aarch64: W: no-documentation hpnssh.spec:607: W: mixed-use-of-spaces-and-tabs (spaces: line 607, tab: line 423) hpnssh.aarch64: W: missing-call-to-setgroups-before-setuid /usr/libexec/hpnssh/hpnssh-keysign hpnssh.aarch64: W: incoherent-version-in-changelog 9.7p1_hpn18.4.0 ['9.7p1_hpn18.4.1-0.fc39', '9.7p1_hpn18.4.1-0'] hpnssh.aarch64: W: empty-%pre hpnssh-server.aarch64: W: dangerous-command-in-%post chmod hpnssh-server.aarch64: W: binary-or-shlib-calls-gethostbyname /usr/sbin/hpnsshd 8 packages and 0 specfiles checked; 17 errors, 12 warnings, 42 filtered, 17 badness; has taken 2.1 s Rpmlint (debuginfo) ------------------- Checking: hpnssh-keycat-debuginfo-9.7p1_hpn18.4.1-0.fc39.aarch64.rpm hpnssh-askpass-debuginfo-9.7p1_hpn18.4.1-0.fc39.aarch64.rpm hpnssh-server-debuginfo-9.7p1_hpn18.4.1-0.fc39.aarch64.rpm hpnssh-clients-debuginfo-9.7p1_hpn18.4.1-0.fc39.aarch64.rpm hpnssh-debuginfo-9.7p1_hpn18.4.1-0.fc39.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_hs88hgk')] checks: 32, packages: 5 5 packages and 0 specfiles checked; 0 errors, 0 warnings, 53 filtered, 0 badness; has taken 1.0 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "hpnssh-debuginfo". (none): E: there is no installed rpm "hpnssh-askpass". (none): E: there is no installed rpm "hpnssh-server-debuginfo". (none): E: there is no installed rpm "hpnssh-keycat-debuginfo". (none): E: there is no installed rpm "hpnssh-keycat". (none): E: there is no installed rpm "hpnssh-askpass-debuginfo". (none): E: there is no installed rpm "hpnssh". (none): E: there is no installed rpm "hpnssh-clients-debuginfo". (none): E: there is no installed rpm "hpnssh-clients". (none): E: there is no installed rpm "hpnssh-server". (none): E: there is no installed rpm "hpnssh-debugsource". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 11 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/rapier1/hpnssh-fedora/blob/main/SOURCES/CJR-GPG-KEY.gpg : CHECKSUM(SHA256) this package : 52110764b80fd3cb3f310a818dcb0a54eee9715b6d82770712be7b63e3c991f8 CHECKSUM(SHA256) upstream package : 53d926e9e132184223790014511b5cd3624aa224aec69c7e793ff1263ac46395 diff -r also reports differences Requires -------- hpnssh (rpmlib, GLIBC filtered): /bin/sh /usr/sbin/nologin audit-libs config(hpnssh) ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libselinux libselinux.so.1()(64bit) libselinux.so.1(LIBSELINUX_1.0)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) hpnssh-clients (rpmlib, GLIBC filtered): /bin/sh /usr/bin/sh config(hpnssh-clients) crypto-policies hpnssh(aarch-64) ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libedit.so.0()(64bit) libfido2.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) libselinux.so.1()(64bit) libselinux.so.1(LIBSELINUX_1.0)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) hpnssh-server (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash /usr/sbin/useradd config(hpnssh-server) crypto-policies hpnssh(aarch-64) ld-linux-aarch64.so.1()(64bit) libaudit.so.1()(64bit) libc.so.6()(64bit) libcom_err.so.2()(64bit) libcrypt.so.2()(64bit) libcrypt.so.2(XCRYPT_2.0)(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgssapi_krb5.so.2()(64bit) libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libselinux.so.1()(64bit) libselinux.so.1(LIBSELINUX_1.0)(64bit) libsystemd.so.0()(64bit) libsystemd.so.0(LIBSYSTEMD_209)(64bit) libz.so.1()(64bit) pam rtld(GNU_HASH) systemd hpnssh-keycat (rpmlib, GLIBC filtered): config(hpnssh-keycat) hpnssh(aarch-64) ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) rtld(GNU_HASH) hpnssh-askpass (rpmlib, GLIBC filtered): hpnssh(aarch-64) ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libgdk-3.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) rtld(GNU_HASH) hpnssh-debuginfo (rpmlib, GLIBC filtered): hpnssh-debugsource (rpmlib, GLIBC filtered): Provides -------- hpnssh: config(hpnssh) hpnssh hpnssh(aarch-64) hpnssh-clients: config(hpnssh-clients) hpnssh-clients hpnssh-clients(aarch-64) hpnssh-server: config(hpnssh-server) group(hpnsshd) hpnssh-server hpnssh-server(aarch-64) user(hpnsshd) hpnssh-keycat: config(hpnssh-keycat) hpnssh-keycat hpnssh-keycat(aarch-64) hpnssh-askpass: hpnssh-askpass hpnssh-askpass(aarch-64) hpnssh-debuginfo: debuginfo(build-id) hpnssh-debuginfo hpnssh-debuginfo(aarch-64) hpnssh-debugsource: hpnssh-debugsource hpnssh-debugsource(aarch-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name hpnssh --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-aarch64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: R, fonts, SugarActivity, PHP, Perl, Java, Python, Haskell, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH