This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'free as beer'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. Note: Multiple Release: tags found [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: DidierStevensSuite-20231016-1.git41b01df.fc39.noarch.rpm DidierStevensSuite-20231016-1.git41b01df.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqnbfqv_n')] checks: 31, packages: 2 DidierStevensSuite.noarch: E: script-without-shebang /usr/bin/make-pdf-helloworld.py DidierStevensSuite.noarch: E: script-without-shebang /usr/bin/simple_listener_templates.py DidierStevensSuite.noarch: W: non-executable-in-bin /usr/bin/make-pdf-helloworld.py 644 DidierStevensSuite.noarch: W: non-executable-in-bin /usr/bin/simple_listener_templates.py 644 DidierStevensSuite.noarch: W: no-version-in-last-changelog DidierStevensSuite.src: W: no-version-in-last-changelog DidierStevensSuite.noarch: W: no-manual-page-for-binary 1768.py DidierStevensSuite.noarch: W: no-manual-page-for-binary MIFAREACR122.py DidierStevensSuite.noarch: W: no-manual-page-for-binary amsiscan.py DidierStevensSuite.noarch: W: no-manual-page-for-binary apc-b.py DidierStevensSuite.noarch: W: no-manual-page-for-binary apc-channel.py DidierStevensSuite.noarch: W: no-manual-page-for-binary apc-pr-log.py DidierStevensSuite.noarch: W: no-manual-page-for-binary base64dump.py DidierStevensSuite.noarch: W: no-manual-page-for-binary byte-stats.py DidierStevensSuite.noarch: W: no-manual-page-for-binary cipher-tool.py DidierStevensSuite.noarch: W: no-manual-page-for-binary cisco-calculate-ssh-fingerprint.py DidierStevensSuite.noarch: W: no-manual-page-for-binary count.py DidierStevensSuite.noarch: W: no-manual-page-for-binary cs-analyze-processdump.py DidierStevensSuite.noarch: W: no-manual-page-for-binary cs-decrypt-metadata.py DidierStevensSuite.noarch: W: no-manual-page-for-binary cs-extract-key.py DidierStevensSuite.noarch: W: no-manual-page-for-binary cs-parse-traffic.py DidierStevensSuite.noarch: W: no-manual-page-for-binary cut-bytes.py DidierStevensSuite.noarch: W: no-manual-page-for-binary decode-vbe.py DidierStevensSuite.noarch: W: no-manual-page-for-binary decoder_add1.py DidierStevensSuite.noarch: W: no-manual-page-for-binary decoder_ah.py DidierStevensSuite.noarch: W: no-manual-page-for-binary decoder_chr.py DidierStevensSuite.noarch: W: no-manual-page-for-binary decoder_rol1.py DidierStevensSuite.noarch: W: no-manual-page-for-binary decoder_xor1.py DidierStevensSuite.noarch: W: no-manual-page-for-binary decompress_rtf.py DidierStevensSuite.noarch: W: no-manual-page-for-binary defuzzer.py DidierStevensSuite.noarch: W: no-manual-page-for-binary disitool.py DidierStevensSuite.noarch: W: no-manual-page-for-binary dns-pydivert.py DidierStevensSuite.noarch: W: no-manual-page-for-binary dns-query-async.py DidierStevensSuite.noarch: W: no-manual-page-for-binary dnsresolver.py DidierStevensSuite.noarch: W: no-manual-page-for-binary emldump.py DidierStevensSuite.noarch: W: no-manual-page-for-binary extractscripts.py DidierStevensSuite.noarch: W: no-manual-page-for-binary file-magic.py DidierStevensSuite.noarch: W: no-manual-page-for-binary file2vbscript.py DidierStevensSuite.noarch: W: no-manual-page-for-binary find-file-in-file.py DidierStevensSuite.noarch: W: no-manual-page-for-binary format-bytes.py DidierStevensSuite.noarch: W: no-manual-page-for-binary generate-hashcat-toggle-rules.py DidierStevensSuite.noarch: W: no-manual-page-for-binary hash.py DidierStevensSuite.noarch: W: no-manual-page-for-binary headtail.py DidierStevensSuite.noarch: W: no-manual-page-for-binary hex-to-bin.py DidierStevensSuite.noarch: W: no-manual-page-for-binary image-forensics-ela.py DidierStevensSuite.noarch: W: no-manual-page-for-binary image-overlay.py DidierStevensSuite.noarch: W: no-manual-page-for-binary jpegdump.py DidierStevensSuite.noarch: W: no-manual-page-for-binary keihash.py DidierStevensSuite.noarch: W: no-manual-page-for-binary lookup-hosts.py DidierStevensSuite.noarch: W: no-manual-page-for-binary lookup-ips.py DidierStevensSuite.noarch: W: no-manual-page-for-binary mPDF.py DidierStevensSuite.noarch: W: no-manual-page-for-binary make-pdf-embedded.py DidierStevensSuite.noarch: W: no-manual-page-for-binary make-pdf-javascript.py DidierStevensSuite.noarch: W: no-manual-page-for-binary make-pdf-jbig2.py DidierStevensSuite.noarch: W: no-manual-page-for-binary msoffcrypto-crack.py DidierStevensSuite.noarch: W: no-manual-page-for-binary myjson-filter.py DidierStevensSuite.noarch: W: no-manual-page-for-binary myjson-transform.py DidierStevensSuite.noarch: W: no-manual-page-for-binary naft-gfe.py DidierStevensSuite.noarch: W: no-manual-page-for-binary naft-icd.py DidierStevensSuite.noarch: W: no-manual-page-for-binary naft-ii.py DidierStevensSuite.noarch: W: no-manual-page-for-binary naft_iipf.py DidierStevensSuite.noarch: W: no-manual-page-for-binary naft_impf.py DidierStevensSuite.noarch: W: no-manual-page-for-binary naft_pfef.py DidierStevensSuite.noarch: W: no-manual-page-for-binary naft_uf.py DidierStevensSuite.noarch: W: no-manual-page-for-binary nmap-xml-script-output.py DidierStevensSuite.noarch: W: no-manual-page-for-binary nsrl.py DidierStevensSuite.noarch: W: no-manual-page-for-binary numbers-to-hex.py DidierStevensSuite.noarch: W: no-manual-page-for-binary numbers-to-string.py DidierStevensSuite.noarch: W: no-manual-page-for-binary oledump.py DidierStevensSuite.noarch: W: no-manual-page-for-binary onion-connect-service-detection.py DidierStevensSuite.noarch: W: no-manual-page-for-binary password-history-analysis.py DidierStevensSuite.noarch: W: no-manual-page-for-binary pcap-rename.py DidierStevensSuite.noarch: W: no-manual-page-for-binary pdf-parser.py DidierStevensSuite.noarch: W: no-manual-page-for-binary pdfid.py DidierStevensSuite.noarch: W: no-manual-page-for-binary pdftool.py DidierStevensSuite.noarch: W: no-manual-page-for-binary pecheck.py DidierStevensSuite.noarch: W: no-manual-page-for-binary peid-userdb-to-yara-rules.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_biff.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_clsid.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_dridex.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_dttm.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_embeddedfile.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_hifo.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_http_heuristics.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_jumplist.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_linear.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_metadata.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_msg.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_msg_summary.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_msi.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_msi_info.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_nameobfuscation.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_office_crypto.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_olestreams.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_pcode_dumper.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_ppt.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_str_sub.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_stream_o.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_stream_sample.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_triage.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_vba.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_vba_dco.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_vba_dir.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_vba_routines.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_vba_summary.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_vbaproject.py DidierStevensSuite.noarch: W: no-manual-page-for-binary plugin_version_vba.py DidierStevensSuite.noarch: W: no-manual-page-for-binary process-binary-file.py DidierStevensSuite.noarch: W: no-manual-page-for-binary process-text-file.py DidierStevensSuite.noarch: W: no-manual-page-for-binary python-per-line.py DidierStevensSuite.noarch: W: no-manual-page-for-binary re-search.py DidierStevensSuite.noarch: W: no-manual-page-for-binary reextra.py DidierStevensSuite.noarch: W: no-manual-page-for-binary rtfdump.py DidierStevensSuite.noarch: W: no-manual-page-for-binary sets.py DidierStevensSuite.noarch: W: no-manual-page-for-binary shellcode2vba.py DidierStevensSuite.noarch: W: no-manual-page-for-binary shellcode2vbscript.py DidierStevensSuite.noarch: W: no-manual-page-for-binary simple-shellcode-generator.py DidierStevensSuite.noarch: W: no-manual-page-for-binary simple_ip_stats.py DidierStevensSuite.noarch: W: no-manual-page-for-binary simple_listener.py DidierStevensSuite.noarch: W: no-manual-page-for-binary simple_tcp_stats.py DidierStevensSuite.noarch: W: no-manual-page-for-binary sortcanon.py DidierStevensSuite.noarch: W: no-manual-page-for-binary split-overlap.py DidierStevensSuite.noarch: W: no-manual-page-for-binary split.py DidierStevensSuite.noarch: W: no-manual-page-for-binary ssdeep.py DidierStevensSuite.noarch: W: no-manual-page-for-binary strings.py DidierStevensSuite.noarch: W: no-manual-page-for-binary teeplus.py DidierStevensSuite.noarch: W: no-manual-page-for-binary texteditor.py DidierStevensSuite.noarch: W: no-manual-page-for-binary translate.py DidierStevensSuite.noarch: W: no-manual-page-for-binary virustotal-search.py DidierStevensSuite.noarch: W: no-manual-page-for-binary virustotal-submit.py DidierStevensSuite.noarch: W: no-manual-page-for-binary vs.py DidierStevensSuite.noarch: W: no-manual-page-for-binary what-is-new.py DidierStevensSuite.noarch: W: no-manual-page-for-binary whatisnewtelegramsendmessage.py DidierStevensSuite.noarch: W: no-manual-page-for-binary wsrradial.py DidierStevensSuite.noarch: W: no-manual-page-for-binary wsrtool.py DidierStevensSuite.noarch: W: no-manual-page-for-binary xmldump.py DidierStevensSuite.noarch: W: no-manual-page-for-binary xor-kpa.py DidierStevensSuite.noarch: W: no-manual-page-for-binary xorsearch.py DidierStevensSuite.noarch: W: no-manual-page-for-binary zipdump.py DidierStevensSuite.noarch: W: no-documentation DidierStevensSuite.noarch: W: invalid-license free as beer DidierStevensSuite.src: W: invalid-license free as beer 2 packages and 0 specfiles checked; 2 errors, 140 warnings, 2 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "DidierStevensSuite". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/DidierStevens/DidierStevensSuite/archive/41b01df75c8bb332f37d2e9eb4c8279583164d0e/DidierStevensSuite-20231016-41b01df.tar.gz : CHECKSUM(SHA256) this package : 13e518ae2b732667b11d0cbf092c81c1ae16e8afe503cf30d07a343d0c3b1930 CHECKSUM(SHA256) upstream package : 13e518ae2b732667b11d0cbf092c81c1ae16e8afe503cf30d07a343d0c3b1930 Requires -------- DidierStevensSuite (rpmlib, GLIBC filtered): /usr/bin/python3 python3-ppdeep xorsearch Provides -------- DidierStevensSuite: DidierStevensSuite Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name DidierStevensSuite --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Python, SugarActivity, Ocaml, fonts, Java, Haskell, PHP, R, Perl, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH