This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782 - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'BSD and MIT and Python'. It seems that you are using the old Fedora license abbreviations. Try `license- fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-oletools See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 23498 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-oletools [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-oletools-0.60.1-1.fc40.noarch.rpm python-oletools-doc-0.60.1-1.fc40.noarch.rpm python-oletools-0.60.1-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpl1m01gco')] checks: 31, packages: 3 python-oletools.spec:195: W: setup-not-quiet python-oletools.spec:346: W: python-setup-test PYTHONIOENCODING=utf8 %{__python2} setup.py test || true python-oletools.spec:351: W: python-setup-test %{__python2} setup.py test || true python3-oletools.noarch: W: no-manual-page-for-binary ezhexviewer python3-oletools.noarch: W: no-manual-page-for-binary ezhexviewer-3 python3-oletools.noarch: W: no-manual-page-for-binary ezhexviewer-3.12 python3-oletools.noarch: W: no-manual-page-for-binary ftguess python3-oletools.noarch: W: no-manual-page-for-binary ftguess-3 python3-oletools.noarch: W: no-manual-page-for-binary ftguess-3.12 python3-oletools.noarch: W: no-manual-page-for-binary mraptor python3-oletools.noarch: W: no-manual-page-for-binary mraptor-3 python3-oletools.noarch: W: no-manual-page-for-binary mraptor-3.12 python3-oletools.noarch: W: no-manual-page-for-binary msodde python3-oletools.noarch: W: no-manual-page-for-binary msodde-3 python3-oletools.noarch: W: no-manual-page-for-binary msodde-3.12 python3-oletools.noarch: W: no-manual-page-for-binary olebrowse python3-oletools.noarch: W: no-manual-page-for-binary olebrowse-3 python3-oletools.noarch: W: no-manual-page-for-binary olebrowse-3.12 python3-oletools.noarch: W: no-manual-page-for-binary oledir python3-oletools.noarch: W: no-manual-page-for-binary oledir-3 python3-oletools.noarch: W: no-manual-page-for-binary oledir-3.12 python3-oletools.noarch: W: no-manual-page-for-binary olefile python3-oletools.noarch: W: no-manual-page-for-binary olefile-3 python3-oletools.noarch: W: no-manual-page-for-binary olefile-3.12 python3-oletools.noarch: W: no-manual-page-for-binary oleid python3-oletools.noarch: W: no-manual-page-for-binary oleid-3 python3-oletools.noarch: W: no-manual-page-for-binary oleid-3.12 python3-oletools.noarch: W: no-manual-page-for-binary olemap python3-oletools.noarch: W: no-manual-page-for-binary olemap-3 python3-oletools.noarch: W: no-manual-page-for-binary olemap-3.12 python3-oletools.noarch: W: no-manual-page-for-binary olemeta python3-oletools.noarch: W: no-manual-page-for-binary olemeta-3 python3-oletools.noarch: W: no-manual-page-for-binary olemeta-3.12 python3-oletools.noarch: W: no-manual-page-for-binary oleobj python3-oletools.noarch: W: no-manual-page-for-binary oleobj-3 python3-oletools.noarch: W: no-manual-page-for-binary oleobj-3.12 python3-oletools.noarch: W: no-manual-page-for-binary oletimes python3-oletools.noarch: W: no-manual-page-for-binary oletimes-3 python3-oletools.noarch: W: no-manual-page-for-binary oletimes-3.12 python3-oletools.noarch: W: no-manual-page-for-binary olevba python3-oletools.noarch: W: no-manual-page-for-binary olevba-3 python3-oletools.noarch: W: no-manual-page-for-binary olevba-3.12 python3-oletools.noarch: W: no-manual-page-for-binary pyxswf python3-oletools.noarch: W: no-manual-page-for-binary pyxswf-3 python3-oletools.noarch: W: no-manual-page-for-binary pyxswf-3.12 python3-oletools.noarch: W: no-manual-page-for-binary rtfobj python3-oletools.noarch: W: no-manual-page-for-binary rtfobj-3 python3-oletools.noarch: W: no-manual-page-for-binary rtfobj-3.12 3 packages and 0 specfiles checked; 0 errors, 48 warnings, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "python-oletools-doc". (none): E: there is no installed rpm "python3-oletools". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/nolze/msoffcrypto-tool/archive/v5.0.0/msoffcrypto-tool-5.0.0.tar.gz : CHECKSUM(SHA256) this package : b6989cafd769669b8d7ba596d7cc9147317aa0badf9188648710776a5752ab62 CHECKSUM(SHA256) upstream package : b6989cafd769669b8d7ba596d7cc9147317aa0badf9188648710776a5752ab62 https://github.com/decalage2/oletools/archive/v0.60.1/oletools-0.60.1.tar.gz : CHECKSUM(SHA256) this package : 34cef47d88488126952f994be7b4c20d2758203b64f69335d3d8179ad3ae0992 CHECKSUM(SHA256) upstream package : 34cef47d88488126952f994be7b4c20d2758203b64f69335d3d8179ad3ae0992 Requires -------- python3-oletools (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3-colorclass python3-cryptography python3-easygui python3-msoffcrypto python3-olefile python3-pcodedmp python3-prettytable python3-pymilter python3-pyparsing python3.12dist(colorclass) python3.12dist(easygui) python3.12dist(msoffcrypto-tool) python3.12dist(olefile) python3.12dist(pcodedmp) python3.12dist(pyparsing) python-oletools-doc (rpmlib, GLIBC filtered): Provides -------- python3-oletools: bundled(oledump) bundled(tablestream) bundled(xglob) bundled(xxxswf) python-oletools python3-oletools python3.12-oletools python3.12dist(oletools) python3dist(oletools) python-oletools-doc: python-oletools-doc python3.12-oletools-doc Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-oletools --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-s390x Active plugins: Generic, Python, Shell-api Disabled plugins: Haskell, Perl, fonts, SugarActivity, PHP, C/C++, R, Java, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH