This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/fish, https://src.fedoraproject.org/modules/fish See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4462550 bytes in 161 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 2", "GNU General Public License, Version 2 and/or Python Software Foundation License 2.0", "MIT License", "GNU General Public License, Version 2", "GNU General Public License, Version 2 and/or GNU Library General Public License, Version 2.0 and/or MIT License", "*No copyright* MIT License", "GNU General Public License v2.0 or later", "BSD 2-Clause License", "GNU Library General Public License v2 or later [obsolete FSF postal address (Mass Ave)]". 2153 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/fish/licensecheck.txt [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: The placement of pkgconfig(.pc) files are correct. Note: fish : /usr/share/pkgconfig/fish.pc [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 5007360 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: fish-4.8.1-1.fc46.x86_64.rpm fish-4.8.1-1.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpc35owca_')] checks: 32, packages: 2 fish.x86_64: W: unstripped-binary-or-object /usr/bin/fish fish.x86_64: W: unstripped-binary-or-object /usr/bin/fish_indent fish.x86_64: W: unstripped-binary-or-object /usr/bin/fish_key_reader fish.src: E: spelling-error ('autosuggestions', '%description -l en_US autosuggestions -> autosuggestion, auto suggestions, auto-suggestions') fish.src: E: spelling-error ('src', '%description -l en_US src -> arc, sec, sic') fish.src: E: spelling-error ('fedoraproject', '%description -l en_US fedoraproject -> fedora project, fedora-project, projector') fish.src: E: spelling-error ('rpms', '%description -l en_US rpms -> rpm, rps, rems') fish.x86_64: E: spelling-error ('autosuggestions', '%description -l en_US autosuggestions -> autosuggestion, auto suggestions, auto-suggestions') fish.x86_64: E: spelling-error ('src', '%description -l en_US src -> arc, sec, sic') fish.x86_64: E: spelling-error ('fedoraproject', '%description -l en_US fedoraproject -> fedora project, fedora-project, projector') fish.x86_64: E: spelling-error ('rpms', '%description -l en_US rpms -> rpm, rps, rems') fish.x86_64: W: hidden-file-or-dir /usr/share/doc/fish/.buildinfo fish.x86_64: W: devel-file-in-non-devel-package /usr/share/pkgconfig/fish.pc 2 packages and 0 specfiles checked; 8 errors, 5 warnings, 7 filtered, 8 badness; has taken 1.0 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "fish". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/fish-shell/fish-shell/releases/download/4.8.1/fish-4.8.1.tar.xz : CHECKSUM(SHA256) this package : 0eb86a851e865e934a7c2091a73d7695225e78f0e00a7bb96d5f877d76c65782 CHECKSUM(SHA256) upstream package : 0eb86a851e865e934a7c2091a73d7695225e78f0e00a7bb96d5f877d76c65782 https://raw.githubusercontent.com/fish-shell/fish-shell/4.8.1/README.rst : CHECKSUM(SHA256) this package : 66385a3c816196439396e500f8066ff1f6c41b9a2ab8b3d7b3c5b52874ab76cc CHECKSUM(SHA256) upstream package : 66385a3c816196439396e500f8066ff1f6c41b9a2ab8b3d7b3c5b52874ab76cc https://raw.githubusercontent.com/fish-shell/fish-shell/4.8.1/COPYING : CHECKSUM(SHA256) this package : 41f2f3709337de306838f27cedebf345c5d4690f68ecced154d57349ca63b85a CHECKSUM(SHA256) upstream package : 41f2f3709337de306838f27cedebf345c5d4690f68ecced154d57349ca63b85a Requires -------- fish (rpmlib, GLIBC filtered): /bin/sh /usr/bin/pkg-config config(fish) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) libpcre2-32.so.0()(64bit) libpcre2-32.so.0(PCRE2_10.47)(64bit) libpcre2-8.so.0()(64bit) libpcre2-8.so.0(PCRE2_10.47)(64bit) rtld(GNU_HASH) Provides -------- fish: config(fish) fish fish(x86-64) pkgconfig(fish) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name fish --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: R, Java, SugarActivity, Haskell, fonts, Ocaml, Python, Perl, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH