This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://src.fedoraproject.org/rpms/cosmic-session
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Naming/#_conflicting_package_names
- systemd_user_post is invoked in %post and systemd_user_preun in %preun
  for Systemd user units service files.
  Note: Systemd user unit service file(s) in cosmic-session
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Scriptlets/#_user_units


===== MUST items =====

C/C++:
[ ]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[ ]: Package does not contain kernel modules.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version
     3", "*No copyright* GNU General Public License, Version 3", "*No
     copyright* Apache License 2.0", "MIT License", "BSD 0-Clause License",
     "*No copyright* MIT License", "*No copyright* The Unlicense", "Apache
     License 2.0 and/or MIT License", "zlib License", "*No copyright* zlib
     License", "*No copyright* Apache License (v2.0) or MIT license",
     "Apache License 2.0", "Unicode License Agreement - Data Files and
     Software (2016)", "*No copyright* Mozilla Public License 2.0", "Apache
     License (v2.0) or MIT license", "*No copyright* Boost Software License
     1.0", "BSD 3-Clause License", "*No copyright* Apache License (v2.0) or
     bsd_ 3-clause_clause", "*No copyright* Apache License 2.0 and/or MIT
     License", "BSD 2-Clause License", "Apache License 2.0 and/or Boost
     Software License 1.0", "BSD 2-Clause with views sentence", "*No
     copyright* Apache License (v2.0) or MIT license and/or MIT License",
     "*No copyright* GNU General Public License, Version 2". 10128 files
     have unknown license. Detailed output of licensecheck in
     /var/lib/copr-rpmbuild/results/cosmic-session/licensecheck.txt
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
     Note: Especially check following dirs for bundled code: /var/lib/copr-
     rpmbuild/results/cosmic-session/upstream-
     unpacked/Source1/vendor/bitflags/src/external, /var/lib/copr-
     rpmbuild/results/cosmic-session/upstream-unpacked/Source1/vendor/pin-
     project-lite/tests/include, /var/lib/copr-rpmbuild/results/cosmic-
     session/upstream-unpacked/Source1/vendor/zerocopy/src/third_party
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: cosmic-session-1.0.0~alpha.3^git20241122.53237d1-1.fc40.aarch64.rpm
          cosmic-session-1.0.0~alpha.3^git20241122.53237d1-1.fc40.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp0f5ux2s0')]
checks: 32, packages: 2

cosmic-session.aarch64: W: no-manual-page-for-binary cosmic-session
cosmic-session.aarch64: W: no-manual-page-for-binary start-cosmic
cosmic-session.aarch64: W: no-documentation
cosmic-session.spec: W: invalid-url Source1: vendor-53237d1.tar.gz
 2 packages and 0 specfiles checked; 0 errors, 4 warnings, 7 filtered, 0 badness; has taken 0.5 s 




Rpmlint (debuginfo)
-------------------
Checking: cosmic-session-debuginfo-1.0.0~alpha.3^git20241122.53237d1-1.fc40.aarch64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpdvswd3ae')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.6 s 





Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "cosmic-session".
(none): E: there is no installed rpm "cosmic-session-debuginfo".
There are no files to process nor additional arguments.
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s 
Nothing to do, aborting.



Source checksums
----------------
https://github.com/pop-os/cosmic-session/archive/53237d147fde1fc63a4be88cf57ec5aaa83d5581/cosmic-session-53237d1.tar.gz :
  CHECKSUM(SHA256) this package     : f06d77d537e35e976d498570c5b6ab9c615875b592cbdf196e12f85cff5acff1
  CHECKSUM(SHA256) upstream package : f06d77d537e35e976d498570c5b6ab9c615875b592cbdf196e12f85cff5acff1


Requires
--------
cosmic-session (rpmlib, GLIBC filtered):
    /usr/bin/bash
    cosmic-app-library
    cosmic-applets
    cosmic-bg
    cosmic-comp
    cosmic-files
    cosmic-greeter
    cosmic-icons
    cosmic-idle
    cosmic-launcher
    cosmic-notifications
    cosmic-osd
    cosmic-panel
    cosmic-randr
    cosmic-screenshot
    cosmic-settings
    cosmic-settings-daemon
    cosmic-workspaces
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3)(64bit)
    libgcc_s.so.1(GCC_4.2.0)(64bit)
    mozilla-fira-mono-fonts
    mozilla-fira-sans-fonts
    rtld(GNU_HASH)
    xdg-desktop-portal-cosmic
    xorg-x11-server-Xwayland



Provides
--------
cosmic-session:
    bundled(crate(addr2line))
    bundled(crate(adler))
    bundled(crate(async-broadcast))
    bundled(crate(async-channel))
    bundled(crate(async-executor))
    bundled(crate(async-fs))
    bundled(crate(async-io))
    bundled(crate(async-lock))
    bundled(crate(async-process))
    bundled(crate(async-recursion))
    bundled(crate(async-signal))
    bundled(crate(async-signals))
    bundled(crate(async-task))
    bundled(crate(async-trait))
    bundled(crate(atomic-waker))
    bundled(crate(autocfg))
    bundled(crate(backtrace))
    bundled(crate(bitflags))
    bundled(crate(block-buffer))
    bundled(crate(blocking))
    bundled(crate(bytemuck))
    bundled(crate(byteorder))
    bundled(crate(bytes))
    bundled(crate(cc))
    bundled(crate(cfg-if))
    bundled(crate(cfg_aliases))
    bundled(crate(color-eyre))
    bundled(crate(color-spantrace))
    bundled(crate(concurrent-queue))
    bundled(crate(cosmic-dbus-a11y))
    bundled(crate(cosmic-notifications-util))
    bundled(crate(cpufeatures))
    bundled(crate(crossbeam-utils))
    bundled(crate(crypto-common))
    bundled(crate(digest))
    bundled(crate(displaydoc))
    bundled(crate(either))
    bundled(crate(endi))
    bundled(crate(enumflags2))
    bundled(crate(enumflags2_derive))
    bundled(crate(equivalent))
    bundled(crate(errno))
    bundled(crate(event-listener))
    bundled(crate(event-listener-strategy))
    bundled(crate(eyre))
    bundled(crate(fast_image_resize))
    bundled(crate(fastrand))
    bundled(crate(form_urlencoded))
    bundled(crate(futures))
    bundled(crate(futures-channel))
    bundled(crate(futures-core))
    bundled(crate(futures-executor))
    bundled(crate(futures-io))
    bundled(crate(futures-lite))
    bundled(crate(futures-macro))
    bundled(crate(futures-sink))
    bundled(crate(futures-task))
    bundled(crate(futures-util))
    bundled(crate(generic-array))
    bundled(crate(getrandom))
    bundled(crate(gimli))
    bundled(crate(hashbrown))
    bundled(crate(hermit-abi))
    bundled(crate(hex))
    bundled(crate(icu_collections))
    bundled(crate(icu_locid))
    bundled(crate(icu_locid_transform))
    bundled(crate(icu_locid_transform_data))
    bundled(crate(icu_normalizer))
    bundled(crate(icu_normalizer_data))
    bundled(crate(icu_properties))
    bundled(crate(icu_properties_data))
    bundled(crate(icu_provider))
    bundled(crate(icu_provider_macros))
    bundled(crate(idna))
    bundled(crate(idna_adapter))
    bundled(crate(indenter))
    bundled(crate(indexmap))
    bundled(crate(itertools))
    bundled(crate(itoa))
    bundled(crate(launch-pad))
    bundled(crate(lazy_static))
    bundled(crate(libc))
    bundled(crate(linux-raw-sys))
    bundled(crate(litemap))
    bundled(crate(lock_api))
    bundled(crate(log))
    bundled(crate(log-panics))
    bundled(crate(matchers))
    bundled(crate(memchr))
    bundled(crate(memoffset))
    bundled(crate(miniz_oxide))
    bundled(crate(mio))
    bundled(crate(nix))
    bundled(crate(nu-ansi-term))
    bundled(crate(num-traits))
    bundled(crate(object))
    bundled(crate(once_cell))
    bundled(crate(ordered-stream))
    bundled(crate(overload))
    bundled(crate(owo-colors))
    bundled(crate(parking))
    bundled(crate(parking_lot))
    bundled(crate(parking_lot_core))
    bundled(crate(percent-encoding))
    bundled(crate(pin-project-lite))
    bundled(crate(pin-utils))
    bundled(crate(piper))
    bundled(crate(polling))
    bundled(crate(ppv-lite86))
    bundled(crate(proc-macro-crate))
    bundled(crate(proc-macro2))
    bundled(crate(quote))
    bundled(crate(rand))
    bundled(crate(rand_chacha))
    bundled(crate(rand_core))
    bundled(crate(redox_syscall))
    bundled(crate(regex))
    bundled(crate(regex-automata))
    bundled(crate(regex-syntax))
    bundled(crate(rustc-demangle))
    bundled(crate(rustix))
    bundled(crate(ryu))
    bundled(crate(scopeguard))
    bundled(crate(sendfd))
    bundled(crate(serde))
    bundled(crate(serde_derive))
    bundled(crate(serde_json))
    bundled(crate(serde_repr))
    bundled(crate(sha1))
    bundled(crate(sharded-slab))
    bundled(crate(shlex))
    bundled(crate(signal-hook-registry))
    bundled(crate(slab))
    bundled(crate(slotmap))
    bundled(crate(smallvec))
    bundled(crate(socket2))
    bundled(crate(stable_deref_trait))
    bundled(crate(static_assertions))
    bundled(crate(syn))
    bundled(crate(sync_wrapper))
    bundled(crate(synstructure))
    bundled(crate(tempfile))
    bundled(crate(thiserror))
    bundled(crate(thiserror-impl))
    bundled(crate(thread_local))
    bundled(crate(tinystr))
    bundled(crate(tokio))
    bundled(crate(tokio-macros))
    bundled(crate(tokio-util))
    bundled(crate(toml_datetime))
    bundled(crate(toml_edit))
    bundled(crate(tracing))
    bundled(crate(tracing-attributes))
    bundled(crate(tracing-core))
    bundled(crate(tracing-error))
    bundled(crate(tracing-journald))
    bundled(crate(tracing-log))
    bundled(crate(tracing-subscriber))
    bundled(crate(typenum))
    bundled(crate(uds_windows))
    bundled(crate(unicode-ident))
    bundled(crate(url))
    bundled(crate(utf16_iter))
    bundled(crate(utf8_iter))
    bundled(crate(valuable))
    bundled(crate(version_check))
    bundled(crate(wasi))
    bundled(crate(winapi))
    bundled(crate(winapi-i686-pc-windows-gnu))
    bundled(crate(winapi-x86_64-pc-windows-gnu))
    bundled(crate(windows-sys))
    bundled(crate(windows-targets))
    bundled(crate(windows_aarch64_gnullvm))
    bundled(crate(windows_aarch64_msvc))
    bundled(crate(windows_i686_gnu))
    bundled(crate(windows_i686_gnullvm))
    bundled(crate(windows_i686_msvc))
    bundled(crate(windows_x86_64_gnu))
    bundled(crate(windows_x86_64_gnullvm))
    bundled(crate(windows_x86_64_msvc))
    bundled(crate(winnow))
    bundled(crate(write16))
    bundled(crate(writeable))
    bundled(crate(xdg-home))
    bundled(crate(yoke))
    bundled(crate(yoke-derive))
    bundled(crate(zbus))
    bundled(crate(zbus_macros))
    bundled(crate(zbus_names))
    bundled(crate(zbus_systemd))
    bundled(crate(zerocopy))
    bundled(crate(zerocopy-derive))
    bundled(crate(zerofrom))
    bundled(crate(zerofrom-derive))
    bundled(crate(zerovec))
    bundled(crate(zerovec-derive))
    bundled(crate(zvariant))
    bundled(crate(zvariant_derive))
    bundled(crate(zvariant_utils))
    cosmic-session
    cosmic-session(aarch-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name cosmic-session --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-40-aarch64
Active plugins: C/C++, Shell-api, Generic
Disabled plugins: Perl, R, Java, Python, fonts, SugarActivity, PHP, Ocaml, Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH