This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file blip_buf.txt is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Mozilla Public License 2.0", "Mozilla Public License 2.0", "BSD 2-Clause License", "GNU Lesser General Public License, Version 2.1", "MIT License", "BSD 3-Clause License", "BSD 3-Clause License and/or JSON License and/or MIT License", "*No copyright* Public domain", "BSD 3-Clause License and/or GNU Lesser General Public License, Version 2.1 and/or MIT License and/or Mozilla Public License 2.0 and/or Public domain", "*No copyright* MIT License", "GNU Lesser General Public License v2.1 or later", "*No copyright* libpng License", "libpng License", "libpng License [generated file]", "FSF Unlimited License (with License Retention) [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "FSF Unlimited License [generated file]", "X11 License [generated file]", "GNU General Public License v2.0 or later", "zlib License", "FSF Unlimited License (with License Retention) and/or GNU General Public License, Version 2", "FSF Unlimited License (with License Retention)", "GNU General Public License, Version 2", "BSD 4-Clause License and/or GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "BSD 4-Clause License", "Apache License 2.0", "GNU General Public License", "*No copyright* Boost Software License 1.0", "Boost Software License 1.0", "NTP License", "*No copyright* zlib License". 1687 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/mgba/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/icons/hicolor/96x96, /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/48x48, /usr/share/icons, /usr/share/man, /usr/share/icons/hicolor, /usr/share/icons/hicolor/16x16, /usr, /usr/share/applications, /usr/share/icons/hicolor/24x24, /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/96x96/apps, /usr/share/doc, /usr/share/icons/hicolor/512x512, /usr/share/icons/hicolor/48x48/apps, /usr/bin, /usr/share, /usr/share/icons/hicolor/64x64/apps, /usr/src/debug, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/16x16/apps, /usr/include, /usr/src, /usr/share/licenses, /usr/share/icons/hicolor/256x256/apps, /usr/lib64, /usr/lib, /usr/share/man/man6, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/32x32 [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/bin, /usr/share/icons/hicolor/96x96, /usr/share/icons/hicolor/24x24/apps, /usr/share, /usr/share/icons/hicolor/64x64/apps, /usr/src/debug, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons, /usr/share/man, /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/16x16, /usr/include, /usr, /usr/src, /usr/share/applications, /usr/share/licenses, /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/24x24, /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/256x256, /usr/lib64, /usr/share/icons/hicolor/96x96/apps, /usr/share/doc, /usr/lib, /usr/share/man/man6, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/512x512, /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/32x32 [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: libmgba-static. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mgba-qt , mgba-data , libmgba , libmgba-static , libmgba-devel [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2304000 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: mgba-0.10.3-1.fc40.x86_64.rpm mgba-qt-0.10.3-1.fc40.x86_64.rpm mgba-data-0.10.3-1.fc40.noarch.rpm mgba-doc-0.10.3-1.fc40.noarch.rpm libmgba-0.10.3-1.fc40.x86_64.rpm libmgba-static-0.10.3-1.fc40.x86_64.rpm libmgba-devel-0.10.3-1.fc40.x86_64.rpm mgba-debuginfo-0.10.3-1.fc40.x86_64.rpm mgba-debugsource-0.10.3-1.fc40.x86_64.rpm mgba-0.10.3-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmply52tkv_')] checks: 32, packages: 10 mgba-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mGBA/README_DE.md mgba-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mGBA/licenses/blip_buf.txt libmgba.x86_64: W: summary-not-capitalized libmgba libmgba-devel.x86_64: W: summary-not-capitalized libmgba-devel libmgba-static.x86_64: W: summary-not-capitalized libmgba-static mgba-doc.noarch: W: summary-not-capitalized mgba doc package mgba-qt.x86_64: W: summary-not-capitalized mgba qt package libmgba-static.x86_64: E: static-library-without-debuginfo /usr/lib64/libmgba-static.a libmgba-devel.x86_64: W: no-version-dependency-on libmgba*/libmgba-libs/liblibmgba* 0.10.3 libmgba.x86_64: E: no-ldconfig-symlink /usr/lib64/libmgba.so.0.10.3 mgba-data.noarch: W: no-documentation libmgba.x86_64: W: name-repeated-in-summary libmgba libmgba-devel.x86_64: W: name-repeated-in-summary libmgba-devel libmgba-static.x86_64: W: name-repeated-in-summary libmgba-static mgba-qt.x86_64: W: files-duplicate /usr/share/mgba/shaders/xbr-lv3.shader/xbr.vs /usr/share/mgba/shaders/xbr-lv2.shader/xbr.vs libmgba-devel.x86_64: W: dangling-relative-symlink /usr/lib64/libmgba.so.0.10 libmgba.so.0.10.3 10 packages and 0 specfiles checked; 2 errors, 14 warnings, 47 filtered, 2 badness; has taken 2.2 s Rpmlint (debuginfo) ------------------- Checking: mgba-debuginfo-0.10.3-1.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp54fk7min')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 10 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "libmgba-static". (none): E: there is no installed rpm "mgba-debugsource". (none): E: there is no installed rpm "mgba-data". (none): E: there is no installed rpm "mgba". (none): E: there is no installed rpm "mgba-debuginfo". (none): E: there is no installed rpm "libmgba". (none): E: there is no installed rpm "libmgba-devel". (none): E: there is no installed rpm "mgba-doc". (none): E: there is no installed rpm "mgba-qt". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 9 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/mgba-emu/mgba/archive/0.10.3.tar.gz#/mgba-0.10.3.tar.gz : CHECKSUM(SHA256) this package : be2cda7de3da8819fdab0c659c5cd4c4b8ca89d9ecddeeeef522db6d31a64143 CHECKSUM(SHA256) upstream package : be2cda7de3da8819fdab0c659c5cd4c4b8ca89d9ecddeeeef522db6d31a64143 Requires -------- mgba (rpmlib, GLIBC filtered): libSDL2-2.0.so.0()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) libmgba.so.0.10()(64bit) mgba-data rtld(GNU_HASH) mgba-qt (rpmlib, GLIBC filtered): libEGL.so.1()(64bit) libGL.so.1()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Multimedia.so.5()(64bit) libQt5Multimedia.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libSDL2-2.0.so.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libmgba.so.0.10()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libswscale.so.7()(64bit) libswscale.so.7(LIBSWSCALE_7)(64bit) mgba-data rtld(GNU_HASH) mgba-data (rpmlib, GLIBC filtered): mgba-doc (rpmlib, GLIBC filtered): libmgba (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libGL.so.1()(64bit) libavcodec.so.60()(64bit) libavcodec.so.60(LIBAVCODEC_60)(64bit) libavfilter.so.9()(64bit) libavfilter.so.9(LIBAVFILTER_9)(64bit) libavformat.so.60()(64bit) libavformat.so.60(LIBAVFORMAT_60)(64bit) libavutil.so.58()(64bit) libavutil.so.58(LIBAVUTIL_58)(64bit) libc.so.6()(64bit) libedit.so.0()(64bit) libelf.so.1()(64bit) libelf.so.1(ELFUTILS_1.0)(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libsqlite3.so.0()(64bit) libswresample.so.4()(64bit) libswresample.so.4(LIBSWRESAMPLE_4)(64bit) libswscale.so.7()(64bit) libswscale.so.7(LIBSWSCALE_7)(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) libzip.so.5()(64bit) rtld(GNU_HASH) libmgba-static (rpmlib, GLIBC filtered): libmgba-devel (rpmlib, GLIBC filtered): libmgba libmgba.so.0.10()(64bit) mgba-debuginfo (rpmlib, GLIBC filtered): mgba-debugsource (rpmlib, GLIBC filtered): Provides -------- mgba: bundled(blip_buf) bundled(inih) mgba mgba(x86-64) mgba-qt: application() application(io.mgba.mGBA.desktop) mgba-qt mgba-qt(x86-64) mimehandler(application/x-agb-rom) mimehandler(application/x-gameboy-advance-rom) mimehandler(application/x-gba-rom) mgba-data: mgba-data mgba-doc: mgba-doc libmgba: libmgba libmgba(x86-64) libmgba.so.0.10()(64bit) libmgba-static: libmgba-static libmgba-static(x86-64) libmgba-devel: libmgba-devel libmgba-devel(x86-64) mgba-debuginfo: debuginfo(build-id) mgba-debuginfo mgba-debuginfo(x86-64) mgba-debugsource: mgba-debugsource mgba-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name mgba --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-40-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Perl, PHP, Ocaml, Python, Haskell, SugarActivity, R, Java, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH