This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rpmdevtools See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "*No copyright* GNU General Public License v2.0 or later", "*No copyright* Public domain". 25 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/rpmdevtools/licensecheck.txt [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 32239 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://releases.pagure.org/rpmdevtools/rpmdevtools-9.7.tar.xz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: rpmdevtools-9.7-1.fc42.noarch.rpm rpmdevtools-9.7-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpj9qhk2qk')] checks: 32, packages: 2 rpmdevtools.noarch: E: spelling-error ('setuptree', '%description -l en_US setuptree -> setup tree, setup-tree, streetwise') rpmdevtools.noarch: E: spelling-error ('newspec', '%description -l en_US newspec -> new spec, new-spec, newspeak') rpmdevtools.noarch: E: spelling-error ('rmdevelrpms', '%description -l en_US rmdevelrpms -> developments') rpmdevtools.noarch: E: spelling-error ('checksig', '%description -l en_US checksig -> checksum') rpmdevtools.noarch: E: spelling-error ('keyring', '%description -l en_US keyring -> keying, key ring, key-ring') rpmdevtools.noarch: E: spelling-error ('sha', '%description -l en_US sha -> aha, sh, ha') rpmdevtools.noarch: E: spelling-error ('checksums', '%description -l en_US checksums -> checksum, check sums, check-sums') rpmdevtools.noarch: E: spelling-error ('vercmp', '%description -l en_US vercmp -> RCMP') rpmdevtools.noarch: E: spelling-error ('specfiles', '%description -l en_US specfiles -> spec files, spec-files, specifiable') rpmdevtools.noarch: E: spelling-error ('wipetree', '%description -l en_US wipetree -> wipe tree, wipe-tree, tripwire') rpmdevtools.noarch: E: spelling-error ('dirs', '%description -l en_US dirs -> rids, sirs, firs') rpmdevtools.noarch: E: spelling-error ('xvf', '%description -l en_US xvf -> xv, xvi, xv f') rpmdevtools.noarch: E: spelling-error ('bumpspec', '%description -l en_US bumpspec -> bump spec, bump-spec, bumper') rpmdevtools.noarch: E: spelling-error ('specfile', '%description -l en_US specfile -> spec file, spec-file, specifiable') rpmdevtools.src: E: spelling-error ('setuptree', '%description -l en_US setuptree -> setup tree, setup-tree, streetwise') rpmdevtools.src: E: spelling-error ('newspec', '%description -l en_US newspec -> new spec, new-spec, newspeak') rpmdevtools.src: E: spelling-error ('rmdevelrpms', '%description -l en_US rmdevelrpms -> developments') rpmdevtools.src: E: spelling-error ('checksig', '%description -l en_US checksig -> checksum') rpmdevtools.src: E: spelling-error ('keyring', '%description -l en_US keyring -> keying, key ring, key-ring') rpmdevtools.src: E: spelling-error ('rpminfo', '%description -l en_US rpminfo -> rpm info, rpm-info, misinform') rpmdevtools.src: E: spelling-error ('sha', '%description -l en_US sha -> aha, sh, ha') rpmdevtools.src: E: spelling-error ('checksums', '%description -l en_US checksums -> checksum, check sums, check-sums') rpmdevtools.src: E: spelling-error ('vercmp', '%description -l en_US vercmp -> RCMP') rpmdevtools.src: E: spelling-error ('spectool', '%description -l en_US spectool -> spec tool, spec-tool, spectator') rpmdevtools.src: E: spelling-error ('specfiles', '%description -l en_US specfiles -> spec files, spec-files, specifiable') rpmdevtools.src: E: spelling-error ('wipetree', '%description -l en_US wipetree -> wipe tree, wipe-tree, tripwire') rpmdevtools.src: E: spelling-error ('dirs', '%description -l en_US dirs -> rids, sirs, firs') rpmdevtools.src: E: spelling-error ('xvf', '%description -l en_US xvf -> xv, xvi, xv f') rpmdevtools.src: E: spelling-error ('bumpspec', '%description -l en_US bumpspec -> bump spec, bump-spec, bumper') rpmdevtools.src: E: spelling-error ('specfile', '%description -l en_US specfile -> spec file, spec-file, specifiable') rpmdevtools.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory rpmdevtools.spec:131: W: shared-dir-glob-in-files %{_bindir}/* rpmdevtools.noarch: W: potential-bashisms /etc/rpmdevtools/template.init rpmdevtools.noarch: E: non-executable-script /etc/rpmdevtools/template.init 644 /bin/sh rpmdevtools.noarch: E: non-executable-script /usr/share/rpmdevtools/tmpdir.sh 644 /bin/sh rpmdevtools.noarch: E: non-executable-script /usr/share/rpmdevtools/trap.sh 644 /bin/sh rpmdevtools.noarch: W: non-conffile-in-etc /etc/bash_completion.d/rpmdevtools.bash-completion rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-checksig rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-cksum rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-md5 rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-setuptree rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-sha1 rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-sha224 rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-sha256 rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-sha384 rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-sha512 rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-sort rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-sum rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-vercmp rpmdevtools.noarch: W: no-manual-page-for-binary rpmdev-wipetree rpmdevtools.noarch: W: no-manual-page-for-binary rpminfo rpmdevtools.noarch: W: no-manual-page-for-binary rpmls rpmdevtools.spec: W: no-%check-section rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-bumpspec rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-checksig rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-cksum rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-diff rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-extract rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-md5 rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-newinit rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-newspec rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-packager rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-rmdevelrpms rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-sha1 rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-sha224 rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-sha256 rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-sha384 rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-sha512 rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-sort rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-spectool rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-sum rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-vercmp rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmdev-wipetree rpmdevtools.noarch: E: incorrect-fsf-address /usr/bin/rpmls rpmdevtools.noarch: E: incorrect-fsf-address /usr/share/licenses/rpmdevtools/COPYING rpmdevtools.noarch: W: files-duplicate /usr/bin/rpmdev-sum /usr/bin/rpmdev-cksum:/usr/bin/rpmdev-md5:/usr/bin/rpmdev-sha1:/usr/bin/rpmdev-sha224:/usr/bin/rpmdev-sha256:(and 2 more) 2 packages and 0 specfiles checked; 55 errors, 21 warnings, 13 filtered, 55 badness; has taken 2.4 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "rpmdevtools". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Requires -------- rpmdevtools (rpmlib, GLIBC filtered): /usr/bin/bash /usr/bin/python3 /usr/bin/sh config(rpmdevtools) curl diffutils emacs-filesystem fakeroot file findutils gawk grep python3dist(argcomplete) python3dist(progressbar2) python3dist(requests) python3dist(rpm) rpm-build sed Provides -------- rpmdevtools: config(rpmdevtools) rpmdevtools Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rpmdevtools --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-42-ppc64le Active plugins: Shell-api, Generic Disabled plugins: Ocaml, Python, Perl, Haskell, R, Java, fonts, SugarActivity, C/C++, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH