This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'BSD'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/lib/copr- rpmbuild/results/i2pd-git/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "BSD 3-Clause License and/or GNU General Public License v2.0 or later", "*No copyright* GNU General Public License v2.0 or later", "Boost Software License 1.0". 289 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/i2pd- git/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /etc/i2pd/tunnels.conf.d, /etc/i2pd, /usr/share/i2pd [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/i2pd, /etc/i2pd/tunnels.conf.d, /etc/i2pd [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/i2pd/subscriptions.txt [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 18852 bytes in 8 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in i2pd-git [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define git_hash %(git rev- parse HEAD | cut -c -7) [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /var/lib/copr-rpmbuild/results/i2pd-git/srpm- unpacked/i2pd-git.spec See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: i2pd-git-2.54.0-git.fc39.x86_64.rpm i2pd-git-debuginfo-2.54.0-git.fc39.x86_64.rpm i2pd-git-debugsource-2.54.0-git.fc39.x86_64.rpm i2pd-git-2.54.0-git.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpolfgwbf2')] checks: 32, packages: 4 i2pd-git.spec: E: specfile-error fatal: not a git repository (or any parent up to mount point /var/lib) i2pd-git.spec: E: specfile-error Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). i2pd-git.x86_64: W: non-standard-uid /var/lib/i2pd i2pd i2pd-git.x86_64: W: non-standard-uid /var/log/i2pd i2pd i2pd-git.x86_64: W: non-standard-gid /var/lib/i2pd i2pd i2pd-git.x86_64: W: non-standard-gid /var/log/i2pd i2pd i2pd-git.x86_64: E: non-standard-dir-perm /var/log/i2pd 700 i2pd-git.x86_64: W: non-conffile-in-etc /etc/i2pd/tunnels.conf.d/README i2pd-git.x86_64: W: non-conffile-in-etc /etc/logrotate.d/i2pd i2pd-git.x86_64: E: logrotate-log-dir-not-packaged "/var/log/i2pd i2pd-git.x86_64: W: incoherent-version-in-changelog 2.54.0 ['2.54.0-git.fc39', '2.54.0-git'] i2pd-git.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/i2pd i2pd-git.x86_64: E: file-parent-ownership-mismatch Path "/var/lib/i2pd/certificates" owned by "root" is stored in directory owned by "i2pd" i2pd-git.x86_64: W: dangling-symlink /var/lib/i2pd/certificates /usr/share/i2pd-git/certificates i2pd-git.x86_64: W: conffile-without-noreplace-flag /etc/i2pd/subscriptions.txt 4 packages and 0 specfiles checked; 6 errors, 9 warnings, 19 filtered, 6 badness; has taken 1.2 s Rpmlint (debuginfo) ------------------- Checking: i2pd-git-debuginfo-2.54.0-git.fc39.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2j07xmct')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.7 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "i2pd-git-debugsource". (none): E: there is no installed rpm "i2pd-git-debuginfo". (none): E: there is no installed rpm "i2pd-git". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/PurpleI2P/i2pd/archive/openssl/i2pd-openssl.tar.gz : CHECKSUM(SHA256) this package : 88d6bd3b3000ed42d7a3e159c613e79b94dbc0a5d7108ede36d64136f904048f CHECKSUM(SHA256) upstream package : f07d2eedb26b201c3726f1446f72a6ad316f352fb20e384b2643d191b1a0d137 diff -r also reports differences Requires -------- i2pd-git (rpmlib, GLIBC filtered): /bin/sh /usr/sbin/groupadd /usr/sbin/useradd config(i2pd-git) libboost_program_options.so.1.81.0()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libminiupnpc.so.17()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libz.so.1()(64bit) logrotate rtld(GNU_HASH) systemd i2pd-git-debuginfo (rpmlib, GLIBC filtered): i2pd-git-debugsource (rpmlib, GLIBC filtered): Provides -------- i2pd-git: config(i2pd-git) i2pd-git i2pd-git(x86-64) i2pd-git-debuginfo: debuginfo(build-id) i2pd-git-debuginfo i2pd-git-debuginfo(x86-64) i2pd-git-debugsource: i2pd-git-debugsource i2pd-git-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name i2pd-git --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Java, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH