This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/arbor See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/lib/copr- rpmbuild/results/arbor/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* Creative Commons Attribution-NonCommercial-ShareAlike 3.0". 1131 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/arbor/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc, /usr/lib64/cmake, /usr/lib64/mpich, /usr/lib64/mpich/lib/cmake, /usr/lib64/mpich/include, /usr/src/debug, /usr/lib64/openmpi/lib/cmake, /usr/share, /usr/lib64/openmpi/share, /usr/src, /usr/lib64/openmpi, /usr, /usr/lib64/mpich/lib, /usr/share/licenses, /usr/lib64/openmpi/include, /usr/lib64, /usr/lib64/openmpi/lib, /usr/lib, /usr/lib64/python3.13, /usr/lib64/mpich/bin, /usr/lib64/mpich/share, /usr/lib64/openmpi/bin, /usr/bin, /usr/lib64/python3.13/site-packages/openmpi, /usr/include, /usr/lib64/python3.13/site-packages/mpich, /usr/lib64/python3.13/site- packages [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc, /usr/lib64/cmake, /usr/lib64/mpich, /usr/lib64/mpich/lib/cmake, /usr/lib64/mpich/include, /usr/src/debug, /usr/lib/.build-id/87, /usr/lib64/openmpi/lib/cmake, /usr/share, /usr/lib64/openmpi/share, /usr/src, /usr/lib64/openmpi, /usr/lib64/mpich/lib, /usr, /usr/share/licenses, /usr/lib64/openmpi/include, /usr/lib64, /usr/lib64/openmpi/lib, /usr/lib, /usr/lib64/python3.13, /usr/lib64/mpich/bin, /usr/lib64/mpich/share, /usr/lib64/openmpi/bin, /usr/bin, /usr/lib64/python3.13/site-packages/openmpi, /usr/include, /usr/lib64/python3.13/site-packages/mpich, /usr/lib64/python3.13/site- packages [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: arbor-devel, arbor-mpich-devel, arbor- openmpi-devel. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5199 bytes in 3 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in arbor- devel , arbor-mpich , arbor-mpich-devel , arbor-openmpi , arbor- openmpi-devel [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /var/lib/copr-rpmbuild/results/arbor/srpm- unpacked/arbor.spec See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: arbor-0.9.0-9.fc41.aarch64.rpm arbor-devel-0.9.0-9.fc41.aarch64.rpm arbor-doc-0.9.0-9.fc41.noarch.rpm arbor-mpich-0.9.0-9.fc41.aarch64.rpm arbor-mpich-devel-0.9.0-9.fc41.aarch64.rpm arbor-openmpi-0.9.0-9.fc41.aarch64.rpm arbor-openmpi-devel-0.9.0-9.fc41.aarch64.rpm arbor-debuginfo-0.9.0-9.fc41.aarch64.rpm arbor-debugsource-0.9.0-9.fc41.aarch64.rpm arbor-0.9.0-9.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_4rr_i3x')] checks: 32, packages: 10 arbor-devel.aarch64: E: static-library-without-debuginfo /usr/lib64/libarbor.a arbor-devel.aarch64: E: static-library-without-debuginfo /usr/lib64/libarborenv.a arbor-devel.aarch64: E: static-library-without-debuginfo /usr/lib64/libarborio.a arbor-mpich-devel.aarch64: E: static-library-without-debuginfo /usr/lib64/mpich/lib/libarbor.a arbor-mpich-devel.aarch64: E: static-library-without-debuginfo /usr/lib64/mpich/lib/libarborenv.a arbor-mpich-devel.aarch64: E: static-library-without-debuginfo /usr/lib64/mpich/lib/libarborio.a arbor-openmpi-devel.aarch64: E: static-library-without-debuginfo /usr/lib64/openmpi/lib/libarbor.a arbor-openmpi-devel.aarch64: E: static-library-without-debuginfo /usr/lib64/openmpi/lib/libarborenv.a arbor-openmpi-devel.aarch64: E: static-library-without-debuginfo /usr/lib64/openmpi/lib/libarborio.a arbor.spec: W: patch-not-applied Patch0: fix-missing-includes.patch arbor.aarch64: W: no-manual-page-for-binary arbor-build-catalogue arbor.aarch64: W: no-manual-page-for-binary lmorpho arbor.aarch64: W: no-manual-page-for-binary modcc arbor-devel.aarch64: W: no-documentation arbor-mpich-devel.aarch64: W: no-documentation arbor-openmpi-devel.aarch64: W: no-documentation arbor-debugsource.aarch64: E: files-duplicated-waste 1462440 10 packages and 0 specfiles checked; 10 errors, 7 warnings, 141 filtered, 10 badness; has taken 3.4 s Rpmlint (debuginfo) ------------------- Checking: arbor-openmpi-debuginfo-0.9.0-9.fc41.aarch64.rpm arbor-debuginfo-0.9.0-9.fc41.aarch64.rpm arbor-mpich-debuginfo-0.9.0-9.fc41.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp75r4lqth')] checks: 32, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 33 filtered, 0 badness; has taken 2.4 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "arbor-mpich". (none): E: there is no installed rpm "arbor-doc". (none): E: there is no installed rpm "arbor-devel". (none): E: there is no installed rpm "arbor-debugsource". (none): E: there is no installed rpm "arbor-debuginfo". (none): E: there is no installed rpm "arbor-openmpi-debuginfo". (none): E: there is no installed rpm "arbor-openmpi". (none): E: there is no installed rpm "arbor-mpich-debuginfo". (none): E: there is no installed rpm "arbor-openmpi-devel". (none): E: there is no installed rpm "arbor-mpich-devel". (none): E: there is no installed rpm "arbor". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 11 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Unversioned so-files -------------------- arbor: /usr/lib64/python3.13/site-packages/arbor/_arbor.cpython-313-aarch64-linux-gnu.so arbor-mpich: /usr/lib64/python3.13/site-packages/mpich/arbor/_arbor.cpython-313-aarch64-linux-gnu.so arbor-openmpi: /usr/lib64/python3.13/site-packages/openmpi/arbor/_arbor.cpython-313-aarch64-linux-gnu.so Source checksums ---------------- https://raw.githubusercontent.com/arbor-sim/arbor/master/scripts/run_cpp_examples.sh : CHECKSUM(SHA256) this package : a730d3f72138c9dc5e7e64489001df15c5a07d6389660a8d50c87e20c7014816 CHECKSUM(SHA256) upstream package : 8d50cd1f2621c3e52bb9760b49a6e679e3ce32930d1a9be24a46c8007dc31118 https://raw.githubusercontent.com/arbor-sim/arbor/master/scripts/run_python_examples.sh : CHECKSUM(SHA256) this package : 92f1dfc5e3831517662d403f7df63b9e6bb1bcbb589be241ddda25c612e8f10c CHECKSUM(SHA256) upstream package : f630cd63675b938e27b8c0bb47e56477f15afbc2a478f0d8843a0b028ceaa3e3 https://github.com/arbor-sim/arbor/archive/v0.9.0/arbor-0.9.0.tar.gz : CHECKSUM(SHA256) this package : 920c7926453379d367c6c8bb01ff867c03e44e8a7a6a5655d5eaa3d692618ca1 CHECKSUM(SHA256) upstream package : 920c7926453379d367c6c8bb01ff867c03e44e8a7a6a5655d5eaa3d692618ca1 diff -r also reports differences Requires -------- arbor (rpmlib, GLIBC filtered): /usr/bin/python3 ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libpugixml.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) python(abi) python3dist(numpy) rtld(GNU_HASH) arbor-devel (rpmlib, GLIBC filtered): arbor(aarch-64) cmake-filesystem(aarch-64) arbor-doc (rpmlib, GLIBC filtered): arbor-mpich (rpmlib, GLIBC filtered): /usr/bin/python3 ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libmpi.so.12()(64bit)(mpich-aarch64) libpugixml.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) mpich python(abi) python3-mpi4py-mpich python3-mpich python3dist(numpy) rtld(GNU_HASH) arbor-mpich-devel (rpmlib, GLIBC filtered): arbor-mpich(aarch-64) arbor-openmpi (rpmlib, GLIBC filtered): /usr/bin/python3 ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libmpi.so.40()(64bit)(openmpi-aarch64) libpugixml.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) openmpi python(abi) python3-mpi4py-openmpi python3-openmpi python3dist(numpy) rtld(GNU_HASH) arbor-openmpi-devel (rpmlib, GLIBC filtered): arbor-openmpi(aarch-64) arbor-debuginfo (rpmlib, GLIBC filtered): arbor-debugsource (rpmlib, GLIBC filtered): Provides -------- arbor: arbor arbor(aarch-64) python3-arbor arbor-devel: arbor-devel arbor-devel(aarch-64) arbor-static cmake(arbor) arbor-doc: arbor-doc arbor-mpich: arbor-mpich arbor-mpich(aarch-64) python3-arbor-mpich arbor-mpich-devel: arbor-mpich-devel arbor-mpich-devel(aarch-64) arbor-mpich-static arbor-openmpi: arbor-openmpi arbor-openmpi(aarch-64) python3-arbor-openmpi arbor-openmpi-devel: arbor-openmpi-devel arbor-openmpi-devel(aarch-64) arbor-openmpi-static arbor-debuginfo: arbor-debuginfo arbor-debuginfo(aarch-64) debuginfo(build-id) arbor-debugsource: arbor-debugsource arbor-debugsource(aarch-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name arbor --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-aarch64 Active plugins: C/C++, Python, Generic, Shell-api Disabled plugins: Java, PHP, SugarActivity, Ocaml, Haskell, fonts, R, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH