{ "issues": [ { "result": "fail", "text": "Package uses either %{buildroot} or $RPM_BUILD_ROOT", "note": "Using both %{buildroot} and $RPM_BUILD_ROOT", "name": "CheckBuildrootMacros", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros" }, { "result": "fail", "text": "Package does not use a name that already exists.", "note": "A package with this name already exists. Please check https://src.fedoraproject.org/rpms/mkvtoolnix, https://src.fedoraproject.org/flatpaks/mkvtoolnix", "name": "CheckNoNameConflict", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names" }, { "result": "fail", "text": "Sources used to build the package match the upstream source, as provided in the spec URL.", "note": "Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/mkvtoolnix/diff.txt", "name": "CheckSourceMD5", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/" } ], "results": { "MUST": { "C/C++": [ { "result": "pass", "text": "If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang.", "note": null, "name": "CheckGccBuildRequires", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/" }, { "result": "pass", "text": "Header files in -devel subpackage, if present.", "note": "", "name": "CheckHeaderFiles", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages" }, { "result": "pass", "text": "Package does not contain any libtool archives (.la)", "note": null, "name": "CheckLibToolArchives", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries" }, { "result": "pending", "text": "Package does not contain kernel modules.", "note": null, "name": "CheckNoKernelModules", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#_no_external_kernel_modules" }, { "result": "pass", "text": "Package contains no static executables.", "note": null, "name": "CheckNoStaticExecutables", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_statically_linking_executables" }, { "result": "pass", "text": "Rpath absent or only used for internal libs.", "note": null, "name": "CheckRPATH", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_beware_of_rpath" } ], "Generic": [ { "result": "pending", "text": "Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.", "note": null, "name": "CheckApprovedLicense", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/" }, { "result": "pending", "text": "%build honors applicable compiler flags or justifies otherwise.", "note": null, "name": "CheckBuildCompilerFlags", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags" }, { "result": "fail", "text": "Package uses either %{buildroot} or $RPM_BUILD_ROOT", "note": "Using both %{buildroot} and $RPM_BUILD_ROOT", "name": "CheckBuildrootMacros", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros" }, { "result": "pending", "text": "Package contains no bundled libraries without FPC exception.", "note": null, "name": "CheckBundledLibs", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling" }, { "result": "pending", "text": "Changelog in prescribed format.", "note": null, "name": "CheckChangelogFormat", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs" }, { "result": "pass", "text": "Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install.", "note": null, "name": "CheckCleanBuildroot", "url": "(this test has no URL)" }, { "result": "pending", "text": "Sources contain only permissible code or content.", "note": null, "name": "CheckCodeAndContent", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#_impermissible_content" }, { "result": "pass", "text": "Macros in Summary, %description expandable at SRPM build time.", "note": null, "name": "CheckDescMacros", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_source_rpm_buildtime_macros" }, { "result": "pass", "text": "Package contains desktop file if it is a GUI application.", "note": null, "name": "CheckDesktopFile", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files" }, { "result": "pass", "text": "Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file.", "note": null, "name": "CheckDesktopFileInstall", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files" }, { "result": "pending", "text": "Development files must be in a -devel package", "note": null, "name": "CheckDevelFilesInDevel", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages" }, { "result": "pending", "text": "Package requires other packages for directories it uses.", "note": "No known owner of /usr/share/man/ca/man1, /usr/share/locale/zh_CN/LC_MESSAGES, /usr/share/icons/hicolor/96x96/apps, /usr/share/locale/nb, /usr/share/man/nl, /usr/src/debug, /usr/share/locale/pl, /usr/share/icons, /usr/share/locale/zh_TW/LC_MESSAGES, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/48x48/apps, /usr/share/man/be/man1, /usr/share/mime/packages, /usr/share/locale/tr/LC_MESSAGES, /usr/share/man/zh_CN, /usr/share/icons/hicolor/32x32/apps, /usr/share/locale/ro/LC_MESSAGES, /usr/share/locale/sv, /usr/share/locale/cs, /usr/share/locale/ca/LC_MESSAGES, /usr/share/licenses, /usr/share/man/ru/man1, /usr/share/locale/lt/LC_MESSAGES, /usr/src, /usr/share/man/bg/man1, /usr/share/locale/pt_BR/LC_MESSAGES, /usr/share/man/ru, /usr/share/man/ko/man1, /usr/share/locale, /usr/share/icons/hicolor/256x256, /usr/share/metainfo, /usr/share/locale/ru, /usr/share/locale/it, /usr/share/locale/zh_SG/LC_MESSAGES, /usr/share/locale/zh_TW, /usr/share/man/zh_CN/man1, /usr/share/man/uk/man1, /usr/share/icons/hicolor/128x128, /usr/bin, /usr/share/locale/pl/LC_MESSAGES, /usr/share/man/nl/man1, /usr/share/locale/ru/LC_MESSAGES, /usr/share/man/man1, /usr/share/locale/tr, /usr/share/man/zh_TW/man1, /usr/share/locale/ja/LC_MESSAGES, /usr/share/man/uk, /usr/share/man/ko, /usr/share/locale/sr_RS@latin, /usr/share/man/fr, /usr/share/man/nb/man1, /usr/share/locale/bg/LC_MESSAGES, /usr/share/locale/bg, /usr/share/applications, /usr/share/man/es, /usr/share/man/ja, /usr/share/locale/be/LC_MESSAGES, /usr/share/locale/fr, /usr/share/locale/pt, /usr/share/man/be, /usr/share/icons/hicolor/64x64/apps, /usr/share/man/ja/man1, /usr/share/locale/sr_RS/LC_MESSAGES, /usr/share/man/pl, /usr/share/doc, /usr/share/locale/ko/LC_MESSAGES, /usr/share/locale/nb/LC_MESSAGES, /usr/share/locale/pt_BR, /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/48x48, /usr/share/man/zh_TW, /usr/share/man/it, /usr/share/mime, /usr/share/locale/cs/LC_MESSAGES, /usr/share/locale/uk/LC_MESSAGES, /usr/share/icons/hicolor/96x96, /usr/share/locale/es, /usr/share/locale/de/LC_MESSAGES, /usr/share/man/es/man1, /usr/share/icons/hicolor/64x64, /usr/share, /usr/share/man, /usr/share/man/de, /usr/share/locale/nl/LC_MESSAGES, /usr/share/locale/eu/LC_MESSAGES, /usr/share/locale/uk, /usr/share/locale/ko, /usr/share/man/ca, /usr/share/icons/hicolor/24x24, /usr/share/man/pl/man1, /usr/share/locale/nl, /usr/share/man/de/man1, /usr/share/locale/es/LC_MESSAGES, /usr/share/locale/pt/LC_MESSAGES, /usr/share/locale/zh_CN, /usr/share/locale/fr/LC_MESSAGES, /usr/share/locale/be, /usr/share/locale/de, /usr/share/icons/hicolor/16x16/apps, /usr/share/man/bg, /usr/share/locale/it/LC_MESSAGES, /usr/share/locale/sr_RS@latin/LC_MESSAGES, /usr/share/locale/ja, /usr/share/locale/ro, /usr/share/locale/sr_RS, /usr/share/icons/hicolor, /usr/share/icons/hicolor/256x256/apps, /usr/share/locale/zh_SG, /usr/share/icons/hicolor/128x128/apps, /usr/share/locale/eu, /usr/share/icons/hicolor/16x16, /usr/share/man/it/man1, /usr/share/locale/sv/LC_MESSAGES, /usr/share/locale/ca, /usr/share/locale/lt, /usr/lib, /usr/share/man/nb, /usr, /usr/share/man/fr/man1", "name": "CheckDirectoryRequire", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership" }, { "result": "pass", "text": "Dist tag is present.", "note": null, "name": "CheckDistTag", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/" }, { "result": "pending", "text": "Package uses nothing in %doc for runtime.", "note": null, "name": "CheckDocRuntime", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation" }, { "result": "pass", "text": "Package does not contain duplicates in %files.", "note": null, "name": "CheckFileDuplicates", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_duplicate_files" }, { "result": "pass", "text": "Permissions on files are set properly.", "note": null, "name": "CheckFilePermissions", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions" }, { "result": "pending", "text": "Package complies to the Packaging Guidelines", "note": null, "name": "CheckGuidelines", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/" }, { "result": "pass", "text": "Package must not depend on deprecated() packages.", "note": null, "name": "CheckIfDepsDeprecated", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/" }, { "result": "pass", "text": "If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license.", "note": null, "name": "CheckLicensInDoc", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text" }, { "result": "pending", "text": "License field in the package spec file matches the actual license.", "note": "Checking patched sources after %prep for licenses. Licenses found: \"Unknown or generated\", \"GNU General Public License, Version 2\", \"*No copyright* Creative Commons Attribution 3.0\", \"GNU General Public License v3.0 or later\", \"FSF Unlimited License [generated file]\", \"Historical Permission Notice and Disclaimer - sell variant [generated file]\", \"FSF All Permissive License\", \"GNU General Public License v2.0 or later\", \"*No copyright* Public domain\", \"*No copyright* GNU General Public License, Version 2\", \"*No copyright* Boost Software License 1.0\", \"GNU Lesser General Public License, Version 2.1\", \"GNU Lesser General Public License, Version 3\", \"MIT License\", \"GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]\", \"*No copyright* GNU Lesser General Public License\", \"GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Mass Ave)]\", \"GNU General Public License\", \"GNU General Public License v2.0 or later and/or MIT License\", \"GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]\", \"*No copyright* GNU General Public License\". 1575 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/mkvtoolnix/licensecheck.txt", "name": "CheckLicenseField", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names" }, { "result": "pass", "text": "The License field must be a valid SPDX expression.", "note": null, "name": "CheckLicenseFieldSPDX", "url": "https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1" }, { "result": "pending", "text": "License file installed when any subpackage combination is installed.", "note": null, "name": "CheckLicenseInSubpackages", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing" }, { "result": "pending", "text": "The spec file handles locales properly.", "note": null, "name": "CheckLocale", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_handling_locale_files" }, { "result": "pending", "text": "Package consistently uses macros (instead of hard-coded directory names).", "note": null, "name": "CheckMacros", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros" }, { "result": "pass", "text": "Package use %makeinstall only when make install DESTDIR=... doesn't work.", "note": null, "name": "CheckMakeinstall", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_why_the_makeinstall_macro_should_not_be_used" }, { "result": "pending", "text": "If the package is under multiple licenses, the licensing breakdown must be documented in the spec.", "note": null, "name": "CheckMultipleLicenses", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios" }, { "result": "pass", "text": "Package is named using only allowed ASCII characters.", "note": null, "name": "CheckNameCharset", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/" }, { "result": "pending", "text": "Package is named according to the Package Naming Guidelines.", "note": null, "name": "CheckNaming", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/" }, { "result": "pending", "text": "Package does not generate any conflict.", "note": null, "name": "CheckNoConflicts", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_conflicts" }, { "result": "fail", "text": "Package does not use a name that already exists.", "note": "A package with this name already exists. Please check https://src.fedoraproject.org/rpms/mkvtoolnix, https://src.fedoraproject.org/flatpaks/mkvtoolnix", "name": "CheckNoNameConflict", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names" }, { "result": "pending", "text": "Package obeys FHS, except libexecdir and /usr/target.", "note": null, "name": "CheckObeysFHS", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_filesystem_layout" }, { "result": "pending", "text": "If the package is a rename of another package, proper Obsoletes and Provides are present.", "note": null, "name": "CheckObsoletesForRename", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages" }, { "result": "pending", "text": "Package must own all directories that it creates.", "note": "Directories without known owners: /usr/share/man/ca/man1, /usr/share/locale/zh_CN/LC_MESSAGES, /usr/share/icons/hicolor/96x96/apps, /usr/share/locale/nb, /usr/share/man/nl, /usr/src/debug, /usr/share/locale/pl, /usr/share/icons, /usr/share/locale/zh_TW/LC_MESSAGES, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/48x48/apps, /usr/share/man/be/man1, /usr/share/mime/packages, /usr/share/locale/tr/LC_MESSAGES, /usr/share/man/zh_CN, /usr/share/icons/hicolor/32x32/apps, /usr/share/locale/ro/LC_MESSAGES, /usr/share/locale/sv, /usr/share/locale/cs, /usr/share/locale/ca/LC_MESSAGES, /usr/share/licenses, /usr/share/man/ru/man1, /usr/share/locale/lt/LC_MESSAGES, /usr/src, /usr/share/man/bg/man1, /usr/share/locale/pt_BR/LC_MESSAGES, /usr/share/man/ru, /usr/share/man/ko/man1, /usr/share/locale, /usr/share/icons/hicolor/256x256, /usr/share/metainfo, /usr/share/locale/ru, /usr/share/locale/it, /usr/share/locale/zh_SG/LC_MESSAGES, /usr/share/locale/zh_TW, /usr/share/man/zh_CN/man1, /usr/share/man/uk/man1, /usr/share/icons/hicolor/128x128, /usr/bin, /usr/share/locale/pl/LC_MESSAGES, /usr/share/man/nl/man1, /usr/share/locale/ru/LC_MESSAGES, /usr/share/man/man1, /usr/share/locale/tr, /usr/share/man/zh_TW/man1, /usr/share/locale/ja/LC_MESSAGES, /usr/share/man/uk, /usr/share/man/ko, /usr/share/locale/sr_RS@latin, /usr/share/man/fr, /usr/share/man/nb/man1, /usr/share/locale/bg/LC_MESSAGES, /usr/share/locale/bg, /usr/share/applications, /usr/share/man/es, /usr/share/man/ja, /usr/share/locale/be/LC_MESSAGES, /usr/share/locale/fr, /usr/share/locale/pt, /usr/share/man/be, /usr/share/icons/hicolor/64x64/apps, /usr/share/man/ja/man1, /usr/share/locale/sr_RS/LC_MESSAGES, /usr/share/man/pl, /usr/share/doc, /usr/share/locale/ko/LC_MESSAGES, /usr/share/locale/nb/LC_MESSAGES, /usr/share/locale/pt_BR, /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/48x48, /usr/share/man/zh_TW, /usr/share/man/it, /usr/share/mime, /usr/share/locale/cs/LC_MESSAGES, /usr/share/locale/uk/LC_MESSAGES, /usr/share/icons/hicolor/96x96, /usr/share/locale/es, /usr/share/locale/de/LC_MESSAGES, /usr/share/man/es/man1, /usr/share/icons/hicolor/64x64, /usr/share, /usr/share/man, /usr/share/man/de, /usr/share/locale/nl/LC_MESSAGES, /usr/share/locale/eu/LC_MESSAGES, /usr/share/locale/uk, /usr/share/locale/ko, /usr/share/man/ca, /usr/share/icons/hicolor/24x24, /usr/share/man/pl/man1, /usr/share/locale/nl, /usr/share/man/de/man1, /usr/share/locale/es/LC_MESSAGES, /usr/share/locale/pt/LC_MESSAGES, /usr/share/locale/zh_CN, /usr/share/locale/fr/LC_MESSAGES, /usr/share/locale/be, /usr/share/locale/de, /usr/share/icons/hicolor/16x16/apps, /usr/share/man/bg, /usr/share/locale/it/LC_MESSAGES, /usr/share/locale/sr_RS@latin/LC_MESSAGES, /usr/share/locale/ja, /usr/share/locale/ro, /usr/share/locale/sr_RS, /usr/share/icons/hicolor, /usr/share/icons/hicolor/256x256/apps, /usr/share/locale/zh_SG, /usr/share/icons/hicolor/128x128/apps, /usr/share/locale/eu, /usr/share/icons/hicolor/16x16, /usr/share/man/it/man1, /usr/share/locale/sv/LC_MESSAGES, /usr/share/locale/ca, /usr/share/locale/lt, /usr/lib, /usr/share/man/nb, /usr, /usr/share/man/fr/man1", "name": "CheckOwnDirs", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership" }, { "result": "pass", "text": "Package does not own files or directories owned by other packages.", "note": null, "name": "CheckOwnOther", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership" }, { "result": "pass", "text": "Package is not relocatable.", "note": null, "name": "CheckRelocatable", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_relocatable_packages" }, { "result": "pending", "text": "Requires correct, justified where necessary.", "note": null, "name": "CheckRequires", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_requires" }, { "result": "fail", "text": "Sources used to build the package match the upstream source, as provided in the spec URL.", "note": "Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/mkvtoolnix/diff.txt", "name": "CheckSourceMD5", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/" }, { "result": "pending", "text": "Spec file is legible and written in American English.", "note": null, "name": "CheckSpecLegibility", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_legibility" }, { "result": "pass", "text": "Spec file name must match the spec package %{name}, in the format %{name}.spec.", "note": null, "name": "CheckSpecName", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming" }, { "result": "pending", "text": "Package contains systemd file(s) if in need.", "note": null, "name": "CheckSystemdScripts", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/" }, { "result": "pass", "text": "File names are valid UTF-8.", "note": null, "name": "CheckUTF8Filenames", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_non_ascii_filenames" }, { "result": "pending", "text": "Useful -debuginfo package or justification otherwise.", "note": null, "name": "CheckUsefulDebuginfo", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_debuginfo_packages" }, { "result": "pending", "text": "Package is not known to require an ExcludeArch tag.", "note": null, "name": "generic-excludearch", "url": "https://fedoraproject.org/wiki/Architectures#ExcludeArch_.26_ExclusiveArch" }, { "result": "pending", "text": "Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files.", "note": "Documentation size is 29796 bytes in 2 files. ", "name": "generic-large-docs", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation" }, { "result": "pass", "text": "Packages must not store files under /srv, /opt or /usr/local", "note": null, "name": "generic-srv-opt", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation" }, { "result": "pending", "text": "Package successfully compiles and builds into binary rpms on at least one supported primary architecture.", "note": "Using prebuilt packages", "name": "CheckBuild", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_support" }, { "result": "pass", "text": "Package installs properly.", "note": null, "name": "CheckPackageInstalls", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/" }, { "result": "pass", "text": "Rpmlint is run on all rpms the build produces.", "note": "There are rpmlint messages (see attachment).", "name": "CheckRpmlint", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_use_rpmlint" } ] }, "SHOULD": { "Generic": [ { "result": "fail", "text": "Reviewer should test that the package builds in mock.", "note": null, "name": "CheckBuildInMock", "url": "https://fedoraproject.org/wiki/PackageMaintainers/MockTricks" }, { "result": "pass", "text": "Buildroot is not present", "note": null, "name": "CheckBuildroot", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/" }, { "result": "pass", "text": "Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT)", "note": null, "name": "CheckClean", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections" }, { "result": "pending", "text": "If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.", "note": null, "name": "CheckContainsLicenseText", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text" }, { "result": "pass", "text": "No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.", "note": null, "name": "CheckFileRequires", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies" }, { "result": "pending", "text": "Final provides and requires are sane (see attachments).", "note": null, "name": "CheckFinalRequiresProvides", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/" }, { "result": "pending", "text": "Fully versioned dependency in subpackages if applicable.", "note": "No Requires: %{name}%{?_isa} = %{version}-%{release} in mkvtoolnix-gui", "name": "CheckFullVerReqSub", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package" }, { "result": "pending", "text": "Package functions as described.", "note": null, "name": "CheckFunctionAsDescribed", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/" }, { "result": "pass", "text": "Packager, Vendor, PreReq, Copyright tags should not be in spec file", "note": null, "name": "CheckIllegalSpecTags", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections" }, { "result": "pending", "text": "Latest version is packaged.", "note": null, "name": "CheckLatestVersionIsPackaged", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/" }, { "result": "pending", "text": "Package does not include license text files separate from upstream.", "note": null, "name": "CheckLicenseUpstream", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text" }, { "result": "pending", "text": "Patches link to upstream bugs/comments/lists or are otherwise justified.", "note": null, "name": "CheckPatchComments", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_patch_guidelines" }, { "result": "pass", "text": "Sources can be downloaded from URI in Source: tag", "note": null, "name": "CheckSourceDownloads", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/" }, { "result": "pass", "text": "SourceX is a working URL.", "note": null, "name": "CheckSourceUrl", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/" }, { "result": "pending", "text": "Sources are verified with gpgverify first in %prep if upstream publishes signatures.", "note": "Sources 0, 1 and 2 are not passed to gpgverify.", "name": "CheckSourceVerification", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_source_file_verification" }, { "result": "pending", "text": "Package should compile and build into binary rpms on all supported architectures.", "note": null, "name": "CheckSupportAllArchs", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_support" }, { "result": "pending", "text": "%check is present and all tests pass.", "note": null, "name": "CheckTestSuites", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites" }, { "result": "pending", "text": "Packages should try to preserve timestamps of original installed files.", "note": null, "name": "CheckTimeStamps", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps" }, { "result": "pass", "text": "Spec use %global instead of %define unless justified.", "note": null, "name": "CheckUseGlobal", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_global_preferred_over_define" } ] }, "EXTRA": { "Generic": [ { "result": "fail", "text": "Large data in /usr/share should live in a noarch subpackage if package is arched.", "note": "Arch-ed rpms have a total of 18360320 bytes in /usr/share mkvtoolnix-86.0-2.fc41.x86_64.rpm:10588160 ", "name": "generic-large-data", "url": "https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines" }, { "result": "pass", "text": "Rpmlint is run on debuginfo package(s).", "note": "No rpmlint messages.", "name": "CheckRpmlintDebuginfo", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_use_rpmlint" }, { "result": "pass", "text": "Rpmlint is run on all installed packages.", "note": "No rpmlint messages.", "name": "CheckRpmlintInstalled", "url": "https://docs.fedoraproject.org/en-US/packaging-guidelines/#_use_rpmlint" }, { "result": "fail", "text": "Spec file according to URL is the same as in SRPM.", "note": "Bad spec filename: /var/lib/copr-rpmbuild/results/mkvtoolnix/srpm-unpacked/mkvtoolnix.spec", "name": "CheckSpecAsInSRPM", "url": "(this test has no URL)" } ] } }, "attachments": [ { "header": "Rpmlint", "text": "Checking: mkvtoolnix-86.0-2.fc41.x86_64.rpm\n mkvtoolnix-gui-86.0-2.fc41.x86_64.rpm\n mkvtoolnix-debuginfo-86.0-2.fc41.x86_64.rpm\n mkvtoolnix-debugsource-86.0-2.fc41.x86_64.rpm\n mkvtoolnix-86.0-2.fc41.src.rpm\n============================ rpmlint session starts ============================\nrpmlint: 2.5.0\nconfiguration:\n /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml\n /etc/xdg/rpmlint/fedora-legacy-licenses.toml\n /etc/xdg/rpmlint/fedora-spdx-licenses.toml\n /etc/xdg/rpmlint/fedora.toml\n /etc/xdg/rpmlint/scoring.toml\n /etc/xdg/rpmlint/users-groups.toml\n /etc/xdg/rpmlint/warn-on-functions.toml\nrpmlintrc: [PosixPath('/tmp/tmpxxsp1f4y')]\nchecks: 32, packages: 5\n\nmkvtoolnix.src: E: spelling-error ('Matroska', 'Summary(en_US) Matroska -> Matron')\nmkvtoolnix.src: E: spelling-error ('mux', '%description -l en_US mux -> mix, mu, mus')\nmkvtoolnix.src: E: spelling-error ('demux', '%description -l en_US demux -> demur')\nmkvtoolnix.x86_64: E: spelling-error ('Matroska', 'Summary(en_US) Matroska -> Matron')\nmkvtoolnix.x86_64: E: spelling-error ('mux', '%description -l en_US mux -> mix, mu, mus')\nmkvtoolnix.x86_64: E: spelling-error ('demux', '%description -l en_US demux -> demur')\nmkvtoolnix-gui.x86_64: E: spelling-error ('mux', '%description -l en_US mux -> mix, mu, mus')\nmkvtoolnix-gui.x86_64: E: spelling-error ('demux', '%description -l en_US demux -> demur')\nmkvtoolnix.x86_64: W: no-manual-page-for-binary base64tool\nmkvtoolnix.x86_64: W: no-manual-page-for-binary diracparser\nmkvtoolnix.x86_64: W: no-manual-page-for-binary ebml_validator\nmkvtoolnix.x86_64: W: no-manual-page-for-binary vc1parser\nmkvtoolnix-gui.x86_64: W: files-duplicate /usr/share/icons/hicolor/128x128/apps/mkvtoolnix-gui.png /usr/share/icons/hicolor/128x128/apps/mkvmerge.png\nmkvtoolnix-gui.x86_64: W: files-duplicate /usr/share/icons/hicolor/16x16/apps/mkvtoolnix-gui.png /usr/share/icons/hicolor/16x16/apps/mkvmerge.png\nmkvtoolnix-gui.x86_64: W: files-duplicate /usr/share/icons/hicolor/24x24/apps/mkvtoolnix-gui.png /usr/share/icons/hicolor/24x24/apps/mkvmerge.png\nmkvtoolnix-gui.x86_64: W: files-duplicate /usr/share/icons/hicolor/256x256/apps/mkvtoolnix-gui.png /usr/share/icons/hicolor/256x256/apps/mkvmerge.png\nmkvtoolnix-gui.x86_64: W: files-duplicate /usr/share/icons/hicolor/32x32/apps/mkvtoolnix-gui.png /usr/share/icons/hicolor/32x32/apps/mkvmerge.png\nmkvtoolnix-gui.x86_64: W: files-duplicate /usr/share/icons/hicolor/48x48/apps/mkvtoolnix-gui.png /usr/share/icons/hicolor/48x48/apps/mkvmerge.png\nmkvtoolnix-gui.x86_64: W: files-duplicate /usr/share/icons/hicolor/64x64/apps/mkvtoolnix-gui.png /usr/share/icons/hicolor/64x64/apps/mkvmerge.png\nmkvtoolnix-gui.x86_64: W: files-duplicate /usr/share/icons/hicolor/96x96/apps/mkvtoolnix-gui.png /usr/share/icons/hicolor/96x96/apps/mkvmerge.png\n 5 packages and 0 specfiles checked; 8 errors, 12 warnings, 56 filtered, 8 badness; has taken 3.9 s \n\n\n" }, { "header": "Rpmlint (installed packages)", "text": "(none): E: there is no installed rpm \"mkvtoolnix-gui-debuginfo\".\n(none): E: there is no installed rpm \"mkvtoolnix\".\n(none): E: there is no installed rpm \"mkvtoolnix-gui\".\n(none): E: there is no installed rpm \"mkvtoolnix-debuginfo\".\n(none): E: there is no installed rpm \"mkvtoolnix-debugsource\".\nThere are no files to process nor additional arguments.\nNothing to do, aborting.\n============================ rpmlint session starts ============================\nrpmlint: 2.5.0\nconfiguration:\n /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml\n /etc/xdg/rpmlint/fedora-legacy-licenses.toml\n /etc/xdg/rpmlint/fedora-spdx-licenses.toml\n /etc/xdg/rpmlint/fedora.toml\n /etc/xdg/rpmlint/scoring.toml\n /etc/xdg/rpmlint/users-groups.toml\n /etc/xdg/rpmlint/warn-on-functions.toml\nchecks: 32, packages: 5\n\n 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s \n\n" }, { "header": "Rpmlint (debuginfo)", "text": "Checking: mkvtoolnix-gui-debuginfo-86.0-2.fc41.x86_64.rpm\n mkvtoolnix-debuginfo-86.0-2.fc41.x86_64.rpm\n============================ rpmlint session starts ============================\nrpmlint: 2.5.0\nconfiguration:\n /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml\n /etc/xdg/rpmlint/fedora-legacy-licenses.toml\n /etc/xdg/rpmlint/fedora-spdx-licenses.toml\n /etc/xdg/rpmlint/fedora.toml\n /etc/xdg/rpmlint/scoring.toml\n /etc/xdg/rpmlint/users-groups.toml\n /etc/xdg/rpmlint/warn-on-functions.toml\nrpmlintrc: [PosixPath('/tmp/tmpfh_1_7vo')]\nchecks: 32, packages: 2\n\n 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 30 filtered, 0 badness; has taken 2.6 s \n\n\n\n" }, { "header": "", "text": "Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24\nCommand line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name mkvtoolnix --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg\nBuildroot used: fedora-rawhide-x86_64\nActive plugins: C/C++, Shell-api, Generic\nDisabled plugins: Perl, Haskell, SugarActivity, R, Java, Ocaml, PHP, Python, fonts\nDisabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH\n" }, { "header": "Source checksums", "text": "https://mkvtoolnix.download/gpg-pub-moritzbunkus.txt :\n CHECKSUM(SHA256) this package : d9b03e47fe81224ccd3a6ee1a3a0c6e7f7ba585ba13089d4e95b72e3188372f5\n CHECKSUM(SHA256) upstream package : 9ff6e67aa8d37ad67e6e6078067d109ece948fccc8aad3bd157e2f57ee71c562\nhttps://mkvtoolnix.download/sources/mkvtoolnix-86.0.tar.xz.sig :\n CHECKSUM(SHA256) this package : 0f69d4343ec83d8b63bd872ffacf808928dc6e634247b9c2aee93932b532c921\n CHECKSUM(SHA256) upstream package : 0f69d4343ec83d8b63bd872ffacf808928dc6e634247b9c2aee93932b532c921\nhttps://mkvtoolnix.download/sources/mkvtoolnix-86.0.tar.xz :\n CHECKSUM(SHA256) this package : 29a9155fbba99f9074de2abcfbdc4e966ea38c16d9f6f547cf2d8d9a48152c97\n CHECKSUM(SHA256) upstream package : 29a9155fbba99f9074de2abcfbdc4e966ea38c16d9f6f547cf2d8d9a48152c97\ndiff -r also reports differences\n" }, { "header": "Requires", "text": "mkvtoolnix (rpmlib, GLIBC filtered):\n libFLAC.so.12()(64bit)\n libQt6Core.so.6()(64bit)\n libQt6Core.so.6(Qt_6)(64bit)\n libQt6Core.so.6(Qt_6.7)(64bit)\n libboost_filesystem.so.1.83.0()(64bit)\n libc.so.6()(64bit)\n libdvdread.so.8()(64bit)\n libebml(x86-64)\n libebml.so.5()(64bit)\n libfmt.so.11()(64bit)\n libgcc_s.so.1()(64bit)\n libgcc_s.so.1(GCC_3.0)(64bit)\n libgcc_s.so.1(GCC_3.3.1)(64bit)\n libgmp.so.10()(64bit)\n libm.so.6()(64bit)\n libmatroska(x86-64)\n libmatroska.so.7()(64bit)\n libogg.so.0()(64bit)\n libpugixml.so.1()(64bit)\n libstdc++.so.6()(64bit)\n libstdc++.so.6(CXXABI_1.3)(64bit)\n libstdc++.so.6(CXXABI_1.3.15)(64bit)\n libstdc++.so.6(CXXABI_1.3.5)(64bit)\n libstdc++.so.6(CXXABI_1.3.9)(64bit)\n libvorbis.so.0()(64bit)\n libz.so.1()(64bit)\n rtld(GNU_HASH)\n\nmkvtoolnix-gui (rpmlib, GLIBC filtered):\n hicolor-icon-theme\n libFLAC.so.12()(64bit)\n libQt6Core.so.6()(64bit)\n libQt6Core.so.6(Qt_6)(64bit)\n libQt6Core.so.6(Qt_6.7)(64bit)\n libQt6Gui.so.6()(64bit)\n libQt6Gui.so.6(Qt_6)(64bit)\n libQt6Multimedia.so.6()(64bit)\n libQt6Multimedia.so.6(Qt_6)(64bit)\n libQt6Network.so.6()(64bit)\n libQt6Network.so.6(Qt_6)(64bit)\n libQt6Widgets.so.6()(64bit)\n libQt6Widgets.so.6(Qt_6)(64bit)\n libboost_filesystem.so.1.83.0()(64bit)\n libc.so.6()(64bit)\n libcmark.so.0.30.3()(64bit)\n libdvdread.so.8()(64bit)\n libebml.so.5()(64bit)\n libfmt.so.11()(64bit)\n libgcc_s.so.1()(64bit)\n libgcc_s.so.1(GCC_3.0)(64bit)\n libgcc_s.so.1(GCC_3.3.1)(64bit)\n libgmp.so.10()(64bit)\n libm.so.6()(64bit)\n libmatroska.so.7()(64bit)\n libpugixml.so.1()(64bit)\n libstdc++.so.6()(64bit)\n libstdc++.so.6(CXXABI_1.3)(64bit)\n libstdc++.so.6(CXXABI_1.3.13)(64bit)\n libstdc++.so.6(CXXABI_1.3.15)(64bit)\n libstdc++.so.6(CXXABI_1.3.3)(64bit)\n libstdc++.so.6(CXXABI_1.3.5)(64bit)\n libstdc++.so.6(CXXABI_1.3.9)(64bit)\n libvorbis.so.0()(64bit)\n mkvtoolnix\n rtld(GNU_HASH)\n\nmkvtoolnix-debuginfo (rpmlib, GLIBC filtered):\n\nmkvtoolnix-debugsource (rpmlib, GLIBC filtered):\n\n" }, { "header": "Provides", "text": "mkvtoolnix:\n bundled(avilib)\n bundled(librmff)\n mkvtoolnix\n mkvtoolnix(x86-64)\n\nmkvtoolnix-gui:\n application()\n application(org.bunkus.mkvtoolnix-gui.desktop)\n metainfo()\n metainfo(org.bunkus.mkvtoolnix-gui.appdata.xml)\n mimehandler(application/x-mkvtoolnix-gui-settings)\n mimehandler(audio/webm)\n mimehandler(audio/x-matroska)\n mimehandler(video/webm)\n mimehandler(video/x-matroska)\n mimehandler(video/x-matroska-3d)\n mkvtoolnix-gui\n mkvtoolnix-gui(x86-64)\n\nmkvtoolnix-debuginfo:\n debuginfo(build-id)\n mkvtoolnix-debuginfo\n mkvtoolnix-debuginfo(x86-64)\n\nmkvtoolnix-debugsource:\n mkvtoolnix-debugsource\n mkvtoolnix-debugsource(x86-64)\n\n" } ] }