This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains no static executables. Note: Static executables found: runsc, gvisor-sentry-prewarmer, gvisor_sentry, checkpointgofer, runsc-fd-parking, runsc-metric-server, gvisor-proc-umounter, containerd-shim-runsc-v1 See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_statically_linking_executables ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0", "MIT License", "*No copyright* Apache License", "BSD 3-Clause License", "Apache License 2.0 and/or MIT License", "BSD 3-Clause License and/or MIT License", "*No copyright* BSD 2-Clause License", "ISC License", "*No copyright* BSD 3-Clause License", "*No copyright* MIT License", "Apache License 2.0 and/or Creative Commons Attribution 4.0", "BSD 2-Clause License", "OpenSSL License", "Apache License 2.0 [generated file]", "Apache License 2.0 and/or GNU Lesser General Public License, Version 3", "Apache License 2.0 and/or BSD 3-Clause License". 3492 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/gvisor/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled() if unbundling is not possible. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5197 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gvisor- containerd , gvisor-selinux [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define gvisor_ldflags %{gobuild_ldflags} -B gobuildid [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1003520 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: gvisor-20261019.0-1.fc46.aarch64.rpm gvisor-containerd-20261019.0-1.fc46.aarch64.rpm gvisor-selinux-20261019.0-1.fc46.noarch.rpm gvisor-20261019.0-1.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpvli7_ccl')] checks: 32, packages: 4 gvisor.aarch64: E: statically-linked-binary /usr/libexec/gvisor/gvisor-bin/checkpointgofer gvisor.aarch64: E: statically-linked-binary /usr/libexec/gvisor/gvisor-bin/gvisor-proc-umounter gvisor.aarch64: E: statically-linked-binary /usr/libexec/gvisor/gvisor-bin/gvisor-sentry-prewarmer gvisor.aarch64: E: statically-linked-binary /usr/libexec/gvisor/gvisor-bin/gvisor_sentry gvisor.aarch64: E: statically-linked-binary /usr/libexec/gvisor/gvisor-bin/runsc-fd-parking gvisor.aarch64: E: statically-linked-binary /usr/libexec/gvisor/gvisor-bin/runsc-metric-server gvisor.aarch64: E: statically-linked-binary /usr/libexec/gvisor/runsc gvisor-containerd.aarch64: E: statically-linked-binary /usr/bin/containerd-shim-runsc-v1 gvisor.src: E: spelling-error ('runsc', '%description -l en_US runsc -> runs, runic, runs c') gvisor.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory gvisor.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory gvisor.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory gvisor.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory gvisor.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory gvisor.aarch64: W: no-manual-page-for-binary runsc gvisor.aarch64: W: no-manual-page-for-binary runsc-kvm gvisor-containerd.aarch64: W: no-manual-page-for-binary containerd-shim-runsc-v1 gvisor-containerd.aarch64: W: no-documentation gvisor-selinux.noarch: W: no-documentation gvisor.spec: W: invalid-url Source1: gvisor-20261019.0-vendor.tar.gz gvisor.aarch64: E: incorrect-fsf-address /usr/share/licenses/gvisor/system-runtime/libgcc/COPYING gvisor.aarch64: E: incorrect-fsf-address /usr/share/licenses/gvisor/system-runtime/libgcc/COPYING.LIB gvisor-selinux.noarch: W: dangerous-command-in-%postun rm gvisor-selinux.noarch: W: dangerous-command-in-%posttrans rm 4 packages and 0 specfiles checked; 11 errors, 13 warnings, 800 filtered, 11 badness; has taken 4.2 s Rpmlint (debuginfo) ------------------- Checking: gvisor-debuginfo-20261019.0-1.fc46.aarch64.rpm gvisor-containerd-debuginfo-20261019.0-1.fc46.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpiz1z9y9c')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 21 filtered, 0 badness; has taken 4.4 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "gvisor-containerd". (none): E: there is no installed rpm "gvisor-containerd-debuginfo". (none): E: there is no installed rpm "gvisor-selinux". (none): E: there is no installed rpm "gvisor". (none): E: there is no installed rpm "gvisor-debuginfo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 5 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://codeload.github.com/google/gvisor/tar.gz/02a34e56a43873ddd1ff5efdda37f63af1b6e7cc#/gvisor-02a34e56a43873ddd1ff5efdda37f63af1b6e7cc.tar.gz : CHECKSUM(SHA256) this package : b73cbc33e5711e26c0321ecef735dde27e5fd5918580d33e0073bf1f7121c725 CHECKSUM(SHA256) upstream package : b73cbc33e5711e26c0321ecef735dde27e5fd5918580d33e0073bf1f7121c725 https://codeload.github.com/google/gvisor/tar.gz/760b80785dc53311d4c87bd2de167525a99709c1#/gvisor-760b80785dc53311d4c87bd2de167525a99709c1.tar.gz : CHECKSUM(SHA256) this package : 5007c4c3082f0ee7dbb85614901ec5e0042f5466033201a730c63b1cd7d8b5f4 CHECKSUM(SHA256) upstream package : 5007c4c3082f0ee7dbb85614901ec5e0042f5466033201a730c63b1cd7d8b5f4 Requires -------- gvisor (rpmlib, GLIBC filtered): /usr/bin/bash gvisor-selinux rtld(GNU_HASH) gvisor-containerd (rpmlib, GLIBC filtered): gvisor(aarch-64) rtld(GNU_HASH) gvisor-selinux (rpmlib, GLIBC filtered): /bin/sh container-selinux libselinux-utils policycoreutils selinux-policy selinux-policy-base selinux-policy-targeted Provides -------- gvisor: bundled(golang(cel.dev/expr)) bundled(golang(cloud.google.com/go)) bundled(golang(cloud.google.com/go/auth)) bundled(golang(cloud.google.com/go/auth/oauth2adapt)) bundled(golang(cloud.google.com/go/compute/metadata)) bundled(golang(cloud.google.com/go/iam)) bundled(golang(cloud.google.com/go/monitoring)) bundled(golang(cloud.google.com/go/storage)) bundled(golang(github.com/BurntSushi/toml)) bundled(golang(github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp)) bundled(golang(github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric)) bundled(golang(github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping)) bundled(golang(github.com/Microsoft/go-winio)) bundled(golang(github.com/Microsoft/hcsshim)) bundled(golang(github.com/cenkalti/backoff)) bundled(golang(github.com/cespare/xxhash/v2)) bundled(golang(github.com/cilium/ebpf)) bundled(golang(github.com/cncf/xds/go)) bundled(golang(github.com/containerd/cgroups/v3)) bundled(golang(github.com/containerd/console)) bundled(golang(github.com/containerd/containerd/api)) bundled(golang(github.com/containerd/containerd/v2)) bundled(golang(github.com/containerd/continuity)) bundled(golang(github.com/containerd/errdefs)) bundled(golang(github.com/containerd/errdefs/pkg)) bundled(golang(github.com/containerd/fifo)) bundled(golang(github.com/containerd/go-runc)) bundled(golang(github.com/containerd/log)) bundled(golang(github.com/containerd/plugin)) bundled(golang(github.com/containerd/ttrpc)) bundled(golang(github.com/containerd/typeurl/v2)) bundled(golang(github.com/coreos/go-systemd/v22)) bundled(golang(github.com/creack/pty)) bundled(golang(github.com/davecgh/go-spew)) bundled(golang(github.com/docker/go-units)) bundled(golang(github.com/emicklei/go-restful/v3)) bundled(golang(github.com/envoyproxy/go-control-plane/envoy)) bundled(golang(github.com/envoyproxy/protoc-gen-validate)) bundled(golang(github.com/felixge/httpsnoop)) bundled(golang(github.com/fxamacker/cbor/v2)) bundled(golang(github.com/go-jose/go-jose/v4)) bundled(golang(github.com/go-logr/logr)) bundled(golang(github.com/go-logr/stdr)) bundled(golang(github.com/go-openapi/jsonpointer)) bundled(golang(github.com/go-openapi/jsonreference)) bundled(golang(github.com/go-openapi/swag)) bundled(golang(github.com/godbus/dbus/v5)) bundled(golang(github.com/gofrs/flock)) bundled(golang(github.com/gogo/protobuf)) bundled(golang(github.com/golang/groupcache)) bundled(golang(github.com/golang/protobuf)) bundled(golang(github.com/google/btree)) bundled(golang(github.com/google/gnostic-models)) bundled(golang(github.com/google/go-cmp)) bundled(golang(github.com/google/gofuzz)) bundled(golang(github.com/google/s2a-go)) bundled(golang(github.com/google/subcommands)) bundled(golang(github.com/google/uuid)) bundled(golang(github.com/googleapis/enterprise-certificate-proxy)) bundled(golang(github.com/googleapis/gax-go/v2)) bundled(golang(github.com/josharian/intern)) bundled(golang(github.com/json-iterator/go)) bundled(golang(github.com/mailru/easyjson)) bundled(golang(github.com/mattbaird/jsonpatch)) bundled(golang(github.com/mdlayher/socket)) bundled(golang(github.com/mdlayher/vsock)) bundled(golang(github.com/moby/sys/capability)) bundled(golang(github.com/moby/sys/mountinfo)) bundled(golang(github.com/moby/sys/userns)) bundled(golang(github.com/modern-go/concurrent)) bundled(golang(github.com/modern-go/reflect2)) bundled(golang(github.com/mohae/deepcopy)) bundled(golang(github.com/munnerz/goautoneg)) bundled(golang(github.com/opencontainers/go-digest)) bundled(golang(github.com/opencontainers/image-spec)) bundled(golang(github.com/opencontainers/runtime-spec)) bundled(golang(github.com/pkg/errors)) bundled(golang(github.com/planetscale/vtprotobuf)) bundled(golang(github.com/sirupsen/logrus)) bundled(golang(github.com/spiffe/go-spiffe/v2)) bundled(golang(github.com/vishvananda/netlink)) bundled(golang(github.com/vishvananda/netns)) bundled(golang(github.com/x448/float16)) bundled(golang(go.opencensus.io)) bundled(golang(go.opentelemetry.io/auto/sdk)) bundled(golang(go.opentelemetry.io/contrib/detectors/gcp)) bundled(golang(go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc)) bundled(golang(go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp)) bundled(golang(go.opentelemetry.io/otel)) bundled(golang(go.opentelemetry.io/otel/metric)) bundled(golang(go.opentelemetry.io/otel/sdk)) bundled(golang(go.opentelemetry.io/otel/sdk/metric)) bundled(golang(go.opentelemetry.io/otel/trace)) bundled(golang(golang.org/x/crypto)) bundled(golang(golang.org/x/exp)) bundled(golang(golang.org/x/mod)) bundled(golang(golang.org/x/net)) bundled(golang(golang.org/x/oauth2)) bundled(golang(golang.org/x/sync)) bundled(golang(golang.org/x/sys)) bundled(golang(golang.org/x/term)) bundled(golang(golang.org/x/text)) bundled(golang(golang.org/x/time)) bundled(golang(golang.org/x/tools)) bundled(golang(google.golang.org/api)) bundled(golang(google.golang.org/genproto)) bundled(golang(google.golang.org/genproto/googleapis/api)) bundled(golang(google.golang.org/genproto/googleapis/rpc)) bundled(golang(google.golang.org/grpc)) bundled(golang(google.golang.org/protobuf)) bundled(golang(gopkg.in/evanphx/json-patch.v4)) bundled(golang(gopkg.in/inf.v0)) bundled(golang(gopkg.in/yaml.v3)) bundled(golang(k8s.io/api)) bundled(golang(k8s.io/apimachinery)) bundled(golang(k8s.io/client-go)) bundled(golang(k8s.io/klog/v2)) bundled(golang(k8s.io/kube-openapi)) bundled(golang(k8s.io/utils)) bundled(golang(sigs.k8s.io/json)) bundled(golang(sigs.k8s.io/structured-merge-diff/v4)) bundled(golang(sigs.k8s.io/yaml)) golang-gvisor golang-gvisor(aarch-64) gvisor gvisor(aarch-64) runsc gvisor-containerd: golang-gvisor-containerd golang-gvisor-containerd(aarch-64) gvisor-containerd gvisor-containerd(aarch-64) gvisor-selinux: golang-gvisor-selinux gvisor-selinux Generated by fedora-review 0.12.0 (a08f0fc) last change: 2026-09-18 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name gvisor --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: PHP, Ocaml, Perl, SugarActivity, R, Java, fonts, Haskell, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH, UNRETIREMENT