This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. Note: Unversionned Python dependency found. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Python/#_dependencies ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated". 82 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/nwg-shell/licensecheck.txt [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.12/site- packages, /usr/lib/python3.12 [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2865 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: nwg-shell-0.5.41-1.fc39.noarch.rpm nwg-shell-0.5.41-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmptoq282of')] checks: 32, packages: 2 nwg-shell.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell/skel/config/hypr/workspaces.conf nwg-shell.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell/skel/config/sway/outputs nwg-shell.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_shell/skel/config/sway/workspaces nwg-shell.spec:101: W: non-break-space line 101, char 30 nwg-shell.spec:104: W: non-break-space line 104, char 30 nwg-shell.spec:107: W: non-break-space line 107, char 30 nwg-shell.spec:110: W: non-break-space line 110, char 30 nwg-shell.spec:113: W: non-break-space line 113, char 30 nwg-shell.spec:116: W: non-break-space line 116, char 30 nwg-shell.spec:119: W: non-break-space line 119, char 30 nwg-shell.spec:122: W: non-break-space line 122, char 30 nwg-shell.spec:125: W: non-break-space line 125, char 30 nwg-shell.spec:128: W: non-break-space line 128, char 30 nwg-shell.spec:131: W: non-break-space line 131, char 30 nwg-shell.spec:134: W: non-break-space line 134, char 30 nwg-shell.spec:137: W: non-break-space line 137, char 30 nwg-shell.spec:140: W: non-break-space line 140, char 30 nwg-shell.spec:143: W: non-break-space line 143, char 30 nwg-shell.spec:146: W: non-break-space line 146, char 30 nwg-shell.spec:149: W: non-break-space line 149, char 30 nwg-shell.spec:152: W: non-break-space line 152, char 30 nwg-shell.spec:155: W: non-break-space line 155, char 30 nwg-shell.spec:158: W: non-break-space line 158, char 30 nwg-shell.spec:161: W: non-break-space line 161, char 30 nwg-shell.spec:164: W: non-break-space line 164, char 30 nwg-shell.spec:167: W: non-break-space line 167, char 30 nwg-shell.spec:170: W: non-break-space line 170, char 30 nwg-shell.spec:173: W: non-break-space line 173, char 30 nwg-shell.spec:176: W: non-break-space line 176, char 30 nwg-shell.spec:179: W: non-break-space line 179, char 30 nwg-shell.spec:182: W: non-break-space line 182, char 30 nwg-shell.spec:185: W: non-break-space line 185, char 30 nwg-shell.spec:188: W: non-break-space line 188, char 30 nwg-shell.spec:191: W: non-break-space line 191, char 30 nwg-shell.spec:194: W: non-break-space line 194, char 30 nwg-shell.spec:197: W: non-break-space line 197, char 30 nwg-shell.spec:200: W: non-break-space line 200, char 30 nwg-shell.spec:203: W: non-break-space line 203, char 30 nwg-shell.spec:206: W: non-break-space line 206, char 30 nwg-shell.spec:212: W: non-break-space line 212, char 30 nwg-shell.noarch: W: no-manual-page-for-binary nwg-shell nwg-shell.noarch: W: no-manual-page-for-binary nwg-shell-check-updates nwg-shell.noarch: W: no-manual-page-for-binary nwg-shell-installer nwg-shell.noarch: W: no-manual-page-for-binary screenshot nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/gtklock/preset-0.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/gtklock/hyprland-0.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/gtklock/preset-1.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/gtklock/hyprland-1.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/gtklock/preset-2.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/gtklock/hyprland-2.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/gtklock/preset-3.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/gtklock/hyprland-3.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-dock/preset-0.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-dock-hyprland/hyprland-0.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-dock/preset-1.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-dock-hyprland/hyprland-1.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-dock/preset-2.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-dock-hyprland/hyprland-2.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-dock/preset-3.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-dock-hyprland/hyprland-3.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-drawer/preset-1.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-drawer/hyprland-1.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-drawer/preset-3.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-drawer/hyprland-2.css:/usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-drawer/preset-2.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-panel/preset-1.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-panel/hyprland-1.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-panel/preset-2.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-panel/hyprland-2.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-panel/preset-3.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/nwg-panel/hyprland-3.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/swaync/hyprland.json /usr/lib/python3.12/site-packages/nwg_shell/skel/config/swaync/config.json nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/swaync/preset-0.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/swaync/hyprland-0.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/swaync/preset-1.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/swaync/hyprland-1.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/swaync/preset-2.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/swaync/hyprland-2.css nwg-shell.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_shell/skel/config/swaync/preset-3.css /usr/lib/python3.12/site-packages/nwg_shell/skel/config/swaync/hyprland-3.css nwg-shell.noarch: E: explicit-lib-dependency libappindicator-gtk3 2 packages and 0 specfiles checked; 4 errors, 59 warnings, 7 filtered, 4 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "nwg-shell". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/nwg-piotr/nwg-shell/archive/v0.5.41/nwg-shell-0.5.41.tar.gz : CHECKSUM(SHA256) this package : 692b9a6b7323e81e2922a600c2ade727cd1ba08d022c558cc5c6a63139599966 CHECKSUM(SHA256) upstream package : 692b9a6b7323e81e2922a600c2ade727cd1ba08d022c558cc5c6a63139599966 Requires -------- nwg-shell (rpmlib, GLIBC filtered): /usr/bin/bash /usr/bin/python3 ImageMagick PolicyKit-authentication-agent azote font(dejavusans) font(dejavusansmono) font(dejavuserif) foot gnome-themes-extra gopsuinfo grim gtk3 gtklock gtklock-playerctl-module gtklock-powerbar-module gtklock-userinfo-module jq libappindicator-gtk3 light network-manager-applet nwg-bar nwg-displays nwg-dock nwg-drawer nwg-look nwg-menu nwg-panel nwg-shell-config nwg-shell-wallpapers papirus-icon-theme playerctl pulseaudio-utils python(abi) python-dasbus python-geopy python-gobject python-yaml slurp swappy sway swaybg swayidle swaylock swaync wl-clipboard wlsunset xorg-x11-server-Xwayland Provides -------- nwg-shell: nwg-shell python3.12dist(nwg-shell) python3dist(nwg-shell) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name nwg-shell --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: fonts, Java, C/C++, Haskell, Ocaml, Perl, PHP, SugarActivity, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH