This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/nwg-panel See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in nwg-panel See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_user_units ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated". 281 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/nwg-panel/licensecheck.txt [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.12/site- packages, /usr/lib/python3.12 [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3964 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: nwg-panel-0.9.58-1.fc40.noarch.rpm nwg-panel-0.9.58-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpp5suengt')] checks: 32, packages: 2 nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/__about__.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/__init__.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/common.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/config.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/dwl_interface.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/icons.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/icons_dark/icon-theme.cache nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/icons_light/icon-theme.cache nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/main.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/__init__.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/brightness_slider.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/clock.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/controls.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/cpu_avg.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/custom_button.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/dwl_tags.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/executor.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/hyprland_submap.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/hyprland_taskbar.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/hyprland_workspaces.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/keyboard_layout.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/menu_start.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/openweather.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/playerctl.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/random_wallpaper.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/scratchpad.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/sway_mode.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/sway_taskbar.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/sway_workspaces.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/modules/swaync.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/processes.py.new nwg-panel.noarch: E: zero-length /usr/lib/python3.12/site-packages/nwg_panel/tools.py.new nwg-panel.noarch: E: spelling-error ('favourites', '%description -l en_US favourites -> favorites, favorite') nwg-panel.noarch: E: spelling-error ('Waybar', '%description -l en_US Waybar -> Way bar, Way-bar, Wayward') nwg-panel.src: E: spelling-error ('favourites', '%description -l en_US favourites -> favorites, favorite') nwg-panel.src: E: spelling-error ('Waybar', '%description -l en_US Waybar -> Way bar, Way-bar, Wayward') nwg-panel.noarch: W: python-leftover-require python3-dasbus nwg-panel.noarch: W: python-leftover-require python3-gobject nwg-panel.noarch: W: python-leftover-require python3-i3ipc nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/common.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/config.py 644 /usr/bin/python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/dwl_interface.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/main.py 644 /usr/bin/python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/brightness_slider.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/clock.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/controls.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/cpu_avg.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/custom_button.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/dwl_tags.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/executor.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/hyprland_submap.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/hyprland_taskbar.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/hyprland_workspaces.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/keyboard_layout.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/menu_start.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/openweather.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/playerctl.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/random_wallpaper.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/scratchpad.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/sway_mode.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/sway_taskbar.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/sway_workspaces.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/modules/swaync.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/processes.py 644 /usr/bin/env python3 nwg-panel.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/nwg_panel/tools.py 644 /usr/bin/env python3 nwg-panel.spec:102: W: non-break-space line 102, char 30 nwg-panel.spec:105: W: non-break-space line 105, char 30 nwg-panel.spec:108: W: non-break-space line 108, char 30 nwg-panel.spec:111: W: non-break-space line 111, char 30 nwg-panel.spec:114: W: non-break-space line 114, char 30 nwg-panel.spec:117: W: non-break-space line 117, char 30 nwg-panel.spec:120: W: non-break-space line 120, char 30 nwg-panel.spec:123: W: non-break-space line 123, char 30 nwg-panel.spec:126: W: non-break-space line 126, char 30 nwg-panel.spec:129: W: non-break-space line 129, char 30 nwg-panel.spec:132: W: non-break-space line 132, char 30 nwg-panel.spec:135: W: non-break-space line 135, char 30 nwg-panel.spec:138: W: non-break-space line 138, char 30 nwg-panel.spec:141: W: non-break-space line 141, char 30 nwg-panel.spec:144: W: non-break-space line 144, char 30 nwg-panel.spec:147: W: non-break-space line 147, char 30 nwg-panel.spec:150: W: non-break-space line 150, char 30 nwg-panel.spec:153: W: non-break-space line 153, char 30 nwg-panel.spec:156: W: non-break-space line 156, char 30 nwg-panel.spec:159: W: non-break-space line 159, char 30 nwg-panel.spec:162: W: non-break-space line 162, char 30 nwg-panel.spec:165: W: non-break-space line 165, char 30 nwg-panel.spec:168: W: non-break-space line 168, char 30 nwg-panel.spec:171: W: non-break-space line 171, char 30 nwg-panel.spec:174: W: non-break-space line 174, char 30 nwg-panel.spec:177: W: non-break-space line 177, char 30 nwg-panel.spec:180: W: non-break-space line 180, char 30 nwg-panel.spec:183: W: non-break-space line 183, char 30 nwg-panel.spec:186: W: non-break-space line 186, char 30 nwg-panel.spec:189: W: non-break-space line 189, char 30 nwg-panel.spec:192: W: non-break-space line 192, char 30 nwg-panel.spec:195: W: non-break-space line 195, char 30 nwg-panel.spec:198: W: non-break-space line 198, char 30 nwg-panel.spec:201: W: non-break-space line 201, char 30 nwg-panel.spec:204: W: non-break-space line 204, char 30 nwg-panel.spec:207: W: non-break-space line 207, char 30 nwg-panel.spec:210: W: non-break-space line 210, char 30 nwg-panel.spec:213: W: non-break-space line 213, char 30 nwg-panel.spec:216: W: non-break-space line 216, char 30 nwg-panel.spec:222: W: non-break-space line 222, char 30 nwg-panel.spec:225: W: non-break-space line 225, char 30 nwg-panel.spec:228: W: non-break-space line 228, char 30 nwg-panel.spec:231: W: non-break-space line 231, char 30 nwg-panel.spec:234: W: non-break-space line 234, char 30 nwg-panel.spec:237: W: non-break-space line 237, char 30 nwg-panel.spec:240: W: non-break-space line 240, char 30 nwg-panel.spec:243: W: non-break-space line 243, char 30 nwg-panel.noarch: W: no-manual-page-for-binary nwg-dwl-interface nwg-panel.noarch: W: no-manual-page-for-binary nwg-panel nwg-panel.noarch: W: no-manual-page-for-binary nwg-panel-config nwg-panel.noarch: W: no-manual-page-for-binary nwg-processes nwg-panel.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_panel/glade/config_sway_mode.glade /usr/lib/python3.12/site-packages/nwg_panel/glade/config_hyprland_submap.glade nwg-panel.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_panel/icons_color/ow-03n.svg /usr/lib/python3.12/site-packages/nwg_panel/icons_color/ow-03d.svg nwg-panel.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_panel/icons_color/ow-09n.svg /usr/lib/python3.12/site-packages/nwg_panel/icons_color/ow-09d.svg nwg-panel.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_panel/icons_color/ow-11n.svg /usr/lib/python3.12/site-packages/nwg_panel/icons_color/ow-11d.svg nwg-panel.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_panel/icons_color/ow-13n.svg /usr/lib/python3.12/site-packages/nwg_panel/icons_color/ow-13d.svg nwg-panel.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_panel/icons_color/ow-50n.svg /usr/lib/python3.12/site-packages/nwg_panel/icons_color/ow-50d.svg nwg-panel.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_panel/icons_light/battery-good-charging-symbolic.svg /usr/lib/python3.12/site-packages/nwg_panel/icons_dark/battery-good-charging-symbolic.svg nwg-panel.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_panel/icons_light/blank.svg /usr/lib/python3.12/site-packages/nwg_panel/icons_dark/blank.svg nwg-panel.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_panel/icons_light/cloud.svg /usr/lib/python3.12/site-packages/nwg_panel/icons_dark/cloud.svg nwg-panel.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_panel/icons_light/wallpaper-refresh.svg /usr/lib/python3.12/site-packages/nwg_panel/icons_dark/wallpaper-refresh.svg nwg-panel.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/nwg_panel/icons_light/wallpaper.svg /usr/lib/python3.12/site-packages/nwg_panel/icons_dark/wallpaper.svg nwg-panel.noarch: W: devel-file-in-non-devel-package /usr/bin/nwg-panel-config 2 packages and 0 specfiles checked; 62 errors, 66 warnings, 8 filtered, 62 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "nwg-panel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/nwg-piotr/nwg-panel/archive/v0.9.58/nwg-panel-0.9.58.tar.gz : CHECKSUM(SHA256) this package : 5dfb964d65845c06d0edb138e41848785378538717b776e01a043cd3ad375ac5 CHECKSUM(SHA256) upstream package : 5dfb964d65845c06d0edb138e41848785378538717b776e01a043cd3ad375ac5 Requires -------- nwg-panel (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash /usr/bin/python3 gtk-layer-shell gtk3 python(abi) python3-dasbus python3-gobject python3-i3ipc python3.12dist(pygobject) wlr-randr Provides -------- nwg-panel: application() application(nwg-panel-config.desktop) nwg-panel python3.12dist(nwg-panel) python3dist(nwg-panel) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name nwg-panel --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-40-aarch64 Active plugins: Shell-api, Python, Generic Disabled plugins: Ocaml, Perl, fonts, Java, PHP, R, SugarActivity, C/C++, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH