%global _trivial .0
%global _buildid .4
# Define common variables for the package
%define _name xfce4-desktop
%define version 4.20.0
%define release 1%{?dist}

Name:           %{_name}
Version:        %{version}
Release:        1%{dist}%{?_trivial}%{?_buildid}
Summary:        A meta-package to install the XFCE4 desktop environment and common utilities.
License:        MIT
BuildArch:      noarch
# No upstream Source needed; this is a meta-package that only manages dependencies
# plus a few config/helper files shipped for optional VNC use.

Source1:     xfce4-panel.xml
Source2:     thunar.xml
Source3:     xstartup
Source4:     xfce4-desktop-vnc-install.sh

# List all required packages. RPM will ensure these are present/installed.
Requires: tigervnc-server
Requires: chromium
Requires: xfce4-session
Requires: xfce4-settings
Requires: xfce4-taskmanager
Requires: xfce4-terminal
Requires: xfce4-vala
Requires: libxfce4windowing
Requires: mousepad
Requires: ristretto
Requires: xarchiver
Requires: xfconf
Requires: xfdashboard
Requires: xfdesktop
Requires: xfwm4
Requires: xfce4-notes-plugin
Requires: xfce4-mount-plugin
Requires: xfce4-about
Requires: xfce4-appfinder
Requires: desktop-backgrounds
Requires: Thunar
Requires: plank
Requires: gnome-icon-theme
Requires: icon-naming-utils
Requires: google-noto-sans-fonts
Requires: google-noto-sans-cjk-sc-fonts
Requires: google-noto-cjk-fonts
Requires: google-noto-sans-mono-cjk-sc-fonts
Requires: google-noto-serif-cjk-sc-fonts
Requires: google-noto-serif-sc-fonts

%description
This package is a meta-package designed to pull in all the necessary
components to set up a full XFCE4 desktop environment, along with
additional utilities and fonts as specified. It simplifies the
installation of a comprehensive XFCE4 environment on compatible systems.

For remote access it ships a ready-made XFCE VNC session script
(%{_datadir}/%{name}/xstartup) and an opt-in helper,
%{_bindir}/xfce4-desktop-vnc-install.sh, which configures a per-user
TigerVNC session on demand. VNC is NOT configured automatically at install.

%install
mkdir -p %{buildroot}%{_datadir}/my-xfce-config/
cp %{SOURCE1} %{buildroot}%{_datadir}/my-xfce-config/default.xml
cp %{SOURCE2} %{buildroot}%{_datadir}/my-xfce-config/thunar.xml

# Ship the VNC XFCE session script as a plain file (installed into a user's
# ~/.vnc/xstartup only when the admin runs xfce4-desktop-vnc-install.sh).
install -d -m 0755 %{buildroot}%{_datadir}/%{name}
install -m 0644 %{SOURCE3} %{buildroot}%{_datadir}/%{name}/xstartup
install -Dm 0755 %{SOURCE4} %{buildroot}%{_bindir}/xfce4-desktop-vnc-install.sh

%posttrans
cp %{_datadir}/my-xfce-config/default.xml /etc/xdg/xfce4/panel/default.xml
cp %{_datadir}/my-xfce-config/thunar.xml /etc/xdg/Thunar/thunar.xml

mkdir -p /etc/xdg/autostart
cat > /etc/xdg/autostart/plank.desktop <<EOF
[Desktop Entry]
Type=Application
Name=Plank
Exec=plank
OnlyShowIn=XFCE;
X-GNOME-Autostart-enabled=true
NoDisplay=false
EOF

%files
%{_datadir}/my-xfce-config/default.xml
%{_datadir}/my-xfce-config/thunar.xml
%dir %{_datadir}/%{name}
%{_datadir}/%{name}/xstartup
%{_bindir}/xfce4-desktop-vnc-install.sh

%changelog
* Sat Jul 04 2026 Yonghang Wang <yhw@amazon.com> - 4.20.0-1
- Replace the firefox dependency with chromium as the default browser.
- Ship the VNC xstartup as a plain file (%{_datadir}/%{name}/xstartup) instead of
  auto-writing it into ec2-user's home at install time.
- Add opt-in helper xfce4-desktop-vnc-install.sh to configure a per-user TigerVNC
  session on demand (copies xstartup, sets password, binds to localhost by default).
- Remove the automatic %post VNC configuration.

* Fri Jul 25 2025 Yonghang Wang <yhw@amazon.com> - 4.18.0-1
- Initial meta-package for XFCE4 desktop environment.
- Configures xstartup for ec2-user if present.